[GitHub] [myfaces] volosied opened a new pull request, #512: MYFACES-4553 - fix placement of flow transition

["volosied (via GitHub)" <gi...@apache.org>]

volosied opened a new pull request, #512:
URL: https://github.com/apache/myfaces/pull/512

   Flow transitioned after a FlowCallNode, but it should be before.
   
   Otherwise, the some flows might not transition due to the `for (int i = didFlowTransitionAlready(facesContext) ? 1 : 0` in applyFlowTransition. 
   
   Basically, a flow could be transition into twice. 
   
   
   Rough outline...
   1) Not in flow
   2) getNavigationCase, begin the node algorithm, and Hit Flow Node
   3) Restart node algorithm
   4) early transition into flow for nested flow
   5) The navigationContext.targetFlows has two flows.  Since the transition marker was set, the first flow would be skipped.     It would transition into the second flow and miss the first. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] volosied merged pull request #512: MYFACES-4553 - fix placement of flow transition

["volosied (via GitHub)" <gi...@apache.org>]

volosied merged PR #512:
URL: https://github.com/apache/myfaces/pull/512


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org