You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Prakash Ramachandran (JIRA)" <ji...@apache.org> on 2014/11/24 06:01:12 UTC

[jira] [Commented] (TEZ-1783) Wrapper in standalone mode.

    [ https://issues.apache.org/jira/browse/TEZ-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222667#comment-14222667 ] 

Prakash Ramachandran commented on TEZ-1783:
-------------------------------------------

overall looks good. few comments

- index.html  href should be relative "img/tez-favicon.png", "/img" wont work if not hosted from /
- config.js  suggestion - do we need to expose the namespaces to user? same about counters
- router.js
  -- typo in comments for setupControllerFactory
  -- setupControllerFactory assumes variable arguments, should be passed from the calling function
- main.less- could have better names for css class push, fifty-fifty - not clear what they do

subjective question - the max width of the page seems to be fixed, given that the tables have lot of columns, would it be better to show
wider table based on available width - for ex on the monitor.

> Wrapper in standalone mode.
> ---------------------------
>
>                 Key: TEZ-1783
>                 URL: https://issues.apache.org/jira/browse/TEZ-1783
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>         Attachments: TEZ-1783.1.patch, apache-tez-logo-transparent.png, tez-favicon.png
>
>
> 1. UI Fit and finish items.
> 2. Limited breadcrumbs to ease navigation 
> 3. Ambari headers and footers even in standalone mode for consistent look & feel
> 4. Configuration support for standalone UI 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)