You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/09 03:09:17 UTC
[GitHub] [flink] wuchong opened a new pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
wuchong opened a new pull request #12047:
URL: https://github.com/apache/flink/pull/12047
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Support the `LookupTableSource` interface in planner.
## Brief change log
Update `CommonLookupJoin` to both handling legacy `LookupableTableSource` and new `LookupTableSource`. We didn't copy a LegacyCommonLookupJoin, because there are too many code can be reused.
## Verifying this change
- Make the existing `LookupJoinTest` and `LookupJoinITCase` to be `Parameterized`, and test both on legacy lookup and new lookup interface.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12047:
URL: https://github.com/apache/flink/pull/12047#issuecomment-626096320
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b718cd9e806a7ade0f9dca948a0b791b9d36cdc2 (Sat May 09 03:12:28 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12047:
URL: https://github.com/apache/flink/pull/12047#discussion_r422508894
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/connector/source/LookupRuntimeProviderContext.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.connector.source;
+
+import org.apache.flink.table.connector.source.DynamicTableSource.DataStructureConverter;
+import org.apache.flink.table.connector.source.LookupTableSource;
+import org.apache.flink.table.data.util.DataFormatConverters.DataFormatConverter;
+import org.apache.flink.table.types.DataType;
+
+import static org.apache.flink.table.data.util.DataFormatConverters.getConverterForDataType;
+
+/**
+ * Implementation of {@link LookupTableSource.Context}. Currently we delegate
+ * {@link #createDataStructureConverter} to {@link DataFormatConverter}.
+ *
+ * <p>In the future, we can code generate the implementation of {@link #createDataStructureConverter}
+ * for better performance.
+ */
+public class LookupRuntimeProviderContext implements LookupTableSource.Context {
+
+ private final int[][] lookupKeys;
+
+ public LookupRuntimeProviderContext(int[][] lookupKeys) {
+ this.lookupKeys = lookupKeys;
Review comment:
The array is a path for selection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on a change in pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #12047:
URL: https://github.com/apache/flink/pull/12047#discussion_r422507099
##########
File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -145,7 +157,9 @@ private static RowKind parseRowKind(String rowKindShortString) {
// Factory
// --------------------------------------------------------------------------------------------
- public static final String IDENTIFIER = "values";
+ public static final AtomicInteger RESOURCE_COUNTER = new AtomicInteger();
+
Review comment:
Thanks for the explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12047:
URL: https://github.com/apache/flink/pull/12047#issuecomment-626098845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b718cd9e806a7ade0f9dca948a0b791b9d36cdc2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b718cd9e806a7ade0f9dca948a0b791b9d36cdc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b718cd9e806a7ade0f9dca948a0b791b9d36cdc2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12047:
URL: https://github.com/apache/flink/pull/12047#issuecomment-626098845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b718cd9e806a7ade0f9dca948a0b791b9d36cdc2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=852",
"triggerID" : "b718cd9e806a7ade0f9dca948a0b791b9d36cdc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b718cd9e806a7ade0f9dca948a0b791b9d36cdc2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=852)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on a change in pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #12047:
URL: https://github.com/apache/flink/pull/12047#discussion_r422474644
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/connector/source/LookupRuntimeProviderContext.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.connector.source;
+
+import org.apache.flink.table.connector.source.DynamicTableSource.DataStructureConverter;
+import org.apache.flink.table.connector.source.LookupTableSource;
+import org.apache.flink.table.data.util.DataFormatConverters.DataFormatConverter;
+import org.apache.flink.table.types.DataType;
+
+import static org.apache.flink.table.data.util.DataFormatConverters.getConverterForDataType;
+
+/**
+ * Implementation of {@link LookupTableSource.Context}. Currently we delegate
+ * {@link #createDataStructureConverter} to {@link DataFormatConverter}.
+ *
+ * <p>In the future, we can code generate the implementation of {@link #createDataStructureConverter}
+ * for better performance.
+ */
+public class LookupRuntimeProviderContext implements LookupTableSource.Context {
+
+ private final int[][] lookupKeys;
+
+ public LookupRuntimeProviderContext(int[][] lookupKeys) {
+ this.lookupKeys = lookupKeys;
Review comment:
Why is `lookupKeys` two-dimensional array.
##########
File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -145,7 +157,9 @@ private static RowKind parseRowKind(String rowKindShortString) {
// Factory
// --------------------------------------------------------------------------------------------
- public static final String IDENTIFIER = "values";
+ public static final AtomicInteger RESOURCE_COUNTER = new AtomicInteger();
+
Review comment:
What is this used for ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on a change in pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #12047:
URL: https://github.com/apache/flink/pull/12047#discussion_r422506993
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/connector/source/LookupRuntimeProviderContext.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.connector.source;
+
+import org.apache.flink.table.connector.source.DynamicTableSource.DataStructureConverter;
+import org.apache.flink.table.connector.source.LookupTableSource;
+import org.apache.flink.table.data.util.DataFormatConverters.DataFormatConverter;
+import org.apache.flink.table.types.DataType;
+
+import static org.apache.flink.table.data.util.DataFormatConverters.getConverterForDataType;
+
+/**
+ * Implementation of {@link LookupTableSource.Context}. Currently we delegate
+ * {@link #createDataStructureConverter} to {@link DataFormatConverter}.
+ *
+ * <p>In the future, we can code generate the implementation of {@link #createDataStructureConverter}
+ * for better performance.
+ */
+public class LookupRuntimeProviderContext implements LookupTableSource.Context {
+
+ private final int[][] lookupKeys;
+
+ public LookupRuntimeProviderContext(int[][] lookupKeys) {
+ this.lookupKeys = lookupKeys;
Review comment:
But IMO, two-dimensional array is not enough, what if there is a column `a.b.c` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12047:
URL: https://github.com/apache/flink/pull/12047#issuecomment-626098845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b718cd9e806a7ade0f9dca948a0b791b9d36cdc2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=852",
"triggerID" : "b718cd9e806a7ade0f9dca948a0b791b9d36cdc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b718cd9e806a7ade0f9dca948a0b791b9d36cdc2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=852)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12047:
URL: https://github.com/apache/flink/pull/12047#discussion_r422508842
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/connector/source/LookupRuntimeProviderContext.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.connector.source;
+
+import org.apache.flink.table.connector.source.DynamicTableSource.DataStructureConverter;
+import org.apache.flink.table.connector.source.LookupTableSource;
+import org.apache.flink.table.data.util.DataFormatConverters.DataFormatConverter;
+import org.apache.flink.table.types.DataType;
+
+import static org.apache.flink.table.data.util.DataFormatConverters.getConverterForDataType;
+
+/**
+ * Implementation of {@link LookupTableSource.Context}. Currently we delegate
+ * {@link #createDataStructureConverter} to {@link DataFormatConverter}.
+ *
+ * <p>In the future, we can code generate the implementation of {@link #createDataStructureConverter}
+ * for better performance.
+ */
+public class LookupRuntimeProviderContext implements LookupTableSource.Context {
+
+ private final int[][] lookupKeys;
+
+ public LookupRuntimeProviderContext(int[][] lookupKeys) {
+ this.lookupKeys = lookupKeys;
Review comment:
It can be expressed. If we have a lookup table , and the lookup key is `r.f.q2`
```sql
CREATE TABLE t1 (r ROW< d DOUBLE, f ROW<q1 STRING, q2 BOOLEAN> >);
```
the array will be `[[0, 1, 1]]` which is equivalent to `[["r", "f", "q2"]]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12047:
URL: https://github.com/apache/flink/pull/12047#discussion_r422485103
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/connector/source/LookupRuntimeProviderContext.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.connector.source;
+
+import org.apache.flink.table.connector.source.DynamicTableSource.DataStructureConverter;
+import org.apache.flink.table.connector.source.LookupTableSource;
+import org.apache.flink.table.data.util.DataFormatConverters.DataFormatConverter;
+import org.apache.flink.table.types.DataType;
+
+import static org.apache.flink.table.data.util.DataFormatConverters.getConverterForDataType;
+
+/**
+ * Implementation of {@link LookupTableSource.Context}. Currently we delegate
+ * {@link #createDataStructureConverter} to {@link DataFormatConverter}.
+ *
+ * <p>In the future, we can code generate the implementation of {@link #createDataStructureConverter}
+ * for better performance.
+ */
+public class LookupRuntimeProviderContext implements LookupTableSource.Context {
+
+ private final int[][] lookupKeys;
+
+ public LookupRuntimeProviderContext(int[][] lookupKeys) {
+ this.lookupKeys = lookupKeys;
Review comment:
See the Javadoc `org.apache.flink.table.connector.source.LookupTableSource.Context#getKeys`, it is in order to support nested lookup keys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12047:
URL: https://github.com/apache/flink/pull/12047#discussion_r422484991
##########
File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -145,7 +157,9 @@ private static RowKind parseRowKind(String rowKindShortString) {
// Factory
// --------------------------------------------------------------------------------------------
- public static final String IDENTIFIER = "values";
+ public static final AtomicInteger RESOURCE_COUNTER = new AtomicInteger();
+
Review comment:
It is used for checking `open` and `close` are both invocked. The `RESOURCE_COUNTER` will be checked in https://github.com/apache/flink/pull/12047/files#diff-46716d3945346195315abf04aa338171R79
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12047:
URL: https://github.com/apache/flink/pull/12047#issuecomment-626264820
Thanks for the reviewing @danny0405 . Yes, they can be cleaned once legacy source is removed.
Will merge this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12047: [FLINK-16990][table-planner-blink] Support LookupTableSource in blink planner
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12047:
URL: https://github.com/apache/flink/pull/12047#issuecomment-626177251
The build CI is passed except a python test failed which is related to FLINK-17597.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org