You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Fuud <gi...@git.apache.org> on 2016/07/12 12:13:54 UTC
[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...
GitHub user Fuud opened a pull request:
https://github.com/apache/maven-surefire/pull/114
Parallel runner should not drop away runners that have zero children.
JUnit does not force runners to include all child tests in Description. Therefore Parallel Runner should not throw such tests away.
For example Spock does not report parametrized tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Fuud/maven-surefire master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #114
----
commit b99002933101eb30074b544c2848f9305503482a
Author: Fedor Bobin <fu...@gmail.com>
Date: 2016-07-12T12:10:37Z
Parallel runner should not drop away runners that have zero children. Childrens can be added during test (for example Spock framework does not report parametrized tests)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
https://issues.apache.org/jira/browse/SUREFIRE-1409
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Any questions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/114#discussion_r91498487
--- Diff: surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java ---
@@ -32,15 +32,13 @@
import org.junit.runner.JUnitCore;
import org.junit.runner.Result;
import org.junit.runner.RunWith;
+import org.junit.runner.notification.RunListener;
+import org.junit.runner.notification.RunNotifier;
+import org.junit.runners.ParentRunner;
import org.junit.runners.Suite;
+import org.junit.runners.model.InitializationError;
-import java.util.ArrayList;
--- End diff --
Pls do not use wildcard `import java.util.*;` and revert this section back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Fuud
We had an internal collision and I tried to recover from this and reverted 11 commits and now trying to fix them and add the last jira fix and then cut the release version. Please try to be patient. We want to continue on this project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
There is one occasion when you set Filter to ParentRunner all children
could be filtered out.
On Fri, May 5, 2017 at 9:52 AM, Fedor Bobin <no...@github.com>
wrote:
> With pure JUnit it is not possible.
> You can only place @Test <https://github.com/Test> annotation on method
> => there will be at least one test in TestClass.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-surefire/pull/114#issuecomment-299403911>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_yR-v0c-4AyptE9r__nA6gET6b0bdiks5r2tUtgaJpZM4JKVF6>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Tests run: 701, Failures: 0, Errors: 0, Skipped: 133
[INFO]
[INFO] --- maven-checkstyle-plugin:2.13:check (checkstyle-check) @ surefire-integration-tests ---
[INFO]
[INFO]
[INFO] --- maven-failsafe-plugin:2.12.4:verify (default) @ surefire-integration-tests ---
[INFO] Failsafe report directory: /tmp/maven-surefire/surefire-integration-tests/target/failsafe-reports
[INFO]
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ surefire-integration-tests ---
[INFO] Skipping artifact installation
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Maven Surefire ............................. SUCCESS [ 2.059 s]
[INFO] ShadeFire JUnit3 Provider ......................... SUCCESS [ 0.831 s]
[INFO] SureFire API ...................................... SUCCESS [ 4.160 s]
[INFO] SureFire Booter ................................... SUCCESS [ 1.175 s]
[INFO] Maven Surefire Test-Grouping Support .............. SUCCESS [ 2.420 s]
[INFO] SureFire Providers ................................ SUCCESS [ 0.339 s]
[INFO] Shared JUnit3 Provider Code ....................... SUCCESS [ 0.522 s]
[INFO] Shared Java 5 Provider Base ....................... SUCCESS [ 0.674 s]
[INFO] Shared JUnit4 Provider Code ....................... SUCCESS [ 0.739 s]
[INFO] Shared JUnit48 Provider Code ...................... SUCCESS [ 1.103 s]
[INFO] SureFire JUnit Runner ............................. SUCCESS [ 0.542 s]
[INFO] SureFire JUnit4 Runner ............................ SUCCESS [ 0.982 s]
[INFO] Maven Surefire Common ............................. SUCCESS [ 4.611 s]
[INFO] SureFire JUnitCore Runner ......................... SUCCESS [ 51.137 s]
[INFO] SureFire TestNG Utils ............................. SUCCESS [ 0.650 s]
[INFO] SureFire TestNG Runner ............................ SUCCESS [ 0.818 s]
[INFO] Surefire Report Parser ............................ SUCCESS [ 1.268 s]
[INFO] Maven Surefire Plugin ............................. SUCCESS [ 4.376 s]
[INFO] Maven Failsafe Plugin ............................. SUCCESS [ 22.047 s]
[INFO] Maven Surefire Report Plugin ...................... SUCCESS [ 5.319 s]
[INFO] Maven Surefire Integration Test Setup ............. SUCCESS [ 15.186 s]
[INFO] Maven Surefire Integration Tests .................. SUCCESS [26:14 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:16 min
[INFO] Finished at: 2016-12-08T10:43:01+01:00
[INFO] Final Memory: 72M/656M
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [GitHub] maven-surefire issue #114: Parallel runner should not
drop away runners that...
Posted by Tibor Digana <ti...@googlemail.com>.
I am sure the code had a reason but currently sorry I have not
answered since I have being preparing fixes for bugs and feature which
are really big.
I keep in mind that I should come back soon.
On 8/29/16, Fuud <gi...@git.apache.org> wrote:
> Github user Fuud commented on the issue:
>
> https://github.com/apache/maven-surefire/pull/114
>
> any updates?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Cheers
Tibor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [GitHub] maven-surefire issue #114: Parallel runner should not
drop away runners that...
Posted by Tibor Digana <ti...@googlemail.com>.
IIUC some runners or Runnable children are added as leafs by your framework
as at the runtime.
I cannot guarantee that these addons would run in parallel.
Is that true that at least some runners still have some children since the
beginning when parallel computer (PC) has recognized them?
On Sat, May 6, 2017 at 4:39 PM, Fuud <gi...@git.apache.org> wrote:
> Github user Fuud commented on the issue:
>
> https://github.com/apache/maven-surefire/pull/114
>
> I am not sure that I understand your question. But I can try to answer
> :)
>
> 1) JUnit has @RunWith annotaion that consumes Class<? extends Runner>
> 2) This Runner should implement method getDescription. But it is not
> prohibited to report via getDescription less children than will be ran.
> 3) There is only one releable method to get all children: run Runner
> and listen to RunNotifier.
> 4) JUnit's default JUnitCore does not skip runners that reports no
> children. Surefire does.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Cheers
Tibor
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
I am not sure that I understand your question. But I can try to answer :)
1) JUnit has @RunWith annotaion that consumes Class<? extends Runner>
2) This Runner should implement method getDescription. But it is not prohibited to report via getDescription less children than will be ran.
3) There is only one releable method to get all children: run Runner and listen to RunNotifier.
4) JUnit's default JUnitCore does not skip runners that reports no children. Surefire does.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Question.
Could it happen that a runner has no children, as e.g. JUnit's runner builder creates runners?
It does not make sense to allocate a thread for empty runner because this is the waste of Threads and such Thread is allocated permanently for no reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by szpak <gi...@git.apache.org>.
Github user szpak commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Tibor17 Is there something else that prevent that PR from being merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/114#discussion_r91397951
--- Diff: surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java ---
@@ -428,10 +428,10 @@ private void determineThreadCounts( long suites, long classes, long methods )
{
int children = countChildren( runner );
childrenCounter += children;
- if ( children != 0 )
- {
+// if ( children != 0 )
--- End diff --
Pls remove the comments in code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
The release would not be that fast. Maybe next month. There is quite a lot
to do.
I need to find spare time to see if the changes in
ParallelComputerBuilder.java
<https://github.com/apache/maven-surefire/pull/114/commits/cde2d2df7f773f86f8b00220b2e350ea356b0ecd#diff-0e5423affd3755b8fd92f5f85886934a>
make logical sense and do not affect testing. If it is ok I will create a
Jira issue for this change from Fuud to have it documented in release notes.
So far we spent a lot of time on massive number of files changes and code
review. The code review is what we are stepping to right now.
I am facing two big tickets and some little which will improve stability of
the plugins.
On Thu, May 4, 2017 at 2:59 AM, Jezorko <no...@github.com> wrote:
> @Tibor17 <https://github.com/Tibor17> I see the current GIT version is
> 2.21-SNAPSHOT
> <https://github.com/apache/maven-surefire/blob/b54e33e68e9c3e13f8fca4b66dbb5c89a0a30715/pom.xml#L32>,
> when a release is expected?
>
> Also a little off-topic, @Fuud <https://github.com/Fuud> is the code for
> your concurrent spock fork available anywhere? I cannot seem to find it.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-surefire/pull/114#issuecomment-299075507>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_yR-8k8JAjzFIznh9yQZkY6VeDoitQks5r2SLigaJpZM4JKVF6>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by huzaus <gi...@git.apache.org>.
Github user huzaus commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@szpak @Fuud
Pls post the test result `mvn install -P run-its`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Fuud
Makes sense.
Why, what is the purpose in your f/w to schedule empty runner?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
>Is that true that at least some runners still have some children since the
beginning when parallel computer (PC) has recognized them?
In general case I can not garantee that.
>>I cannot guarantee that these addons would run in parallel.
JUnit's ParallelComputer sets scheduler to ParentRunner. Spock uses this scheduler to run children. Everything should just work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Jezorko <gi...@git.apache.org>.
Github user Jezorko commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Tibor17 I see [the current GIT version is 2.21-SNAPSHOT](https://github.com/apache/maven-surefire/blob/b54e33e68e9c3e13f8fca4b66dbb5c89a0a30715/pom.xml#L32), when a release is expected?
Also a little off-topic, @Fuud is the code for your concurrent spock fork available anywhere? I cannot seem to find it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Fuud
You mean this PR does not pass on Win or the master origin?
Please see our Jenkins on Windows. It passed https://builds.apache.org/job/maven-surefire-windows
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Just FYI: integration tests suite does not pass on Windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
NoTestsRemainException will be thrown in this case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/114#discussion_r91491402
--- Diff: surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java ---
@@ -428,10 +428,10 @@ private void determineThreadCounts( long suites, long classes, long methods )
{
int children = countChildren( runner );
childrenCounter += children;
- if ( children != 0 )
- {
+// if ( children != 0 )
--- End diff --
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Fuud
This branch was rebased and pushed to master. Please close it.
Thx for contributing.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud closed the pull request at:
https://github.com/apache/maven-surefire/pull/114
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Jezorko
https://github.com/spockframework/spock/pull/558
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
With pure JUnit it is not possible.
You can only place @Test annotation on method => there will be at least one test in TestClass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
I have this PR in my mind, do not worry. The problem is that we may cleanup
our codeline and I do not want to loose your path in master after we
revert. Pls wait few days.
On Sun, Jan 8, 2017 at 12:33 AM, Marcin Zaj\u0105czkowski <
notifications@github.com> wrote:
> @Tibor17 <https://github.com/Tibor17> Is there something else that
> prevent that PR from being merged?
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-surefire/pull/114#issuecomment-271117788>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_yR6sSEkJR4g8Q_w-jFJyV_Guxut6Yks5rQCCygaJpZM4JKVF6>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/114#discussion_r91513593
--- Diff: surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java ---
@@ -32,15 +32,13 @@
import org.junit.runner.JUnitCore;
import org.junit.runner.Result;
import org.junit.runner.RunWith;
+import org.junit.runner.notification.RunListener;
+import org.junit.runner.notification.RunNotifier;
+import org.junit.runners.ParentRunner;
import org.junit.runners.Suite;
+import org.junit.runners.model.InitializationError;
-import java.util.ArrayList;
--- End diff --
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
IIYC you mean test-methods by "children".
The classes and suites are under our control mean ParallelComputer only? Is
it under Spock control as well?
On Wed, May 10, 2017 at 6:40 AM, Fedor Bobin <no...@github.com>
wrote:
> Is that true that at least some runners still have some children since the
> beginning when parallel computer (PC) has recognized them?
>
> In general case I can not garantee that.
>
> I cannot guarantee that these addons would run in parallel.
>
> JUnit's ParallelComputer sets scheduler to ParentRunner. Spock uses this
> scheduler to run children. Everything should just work.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-surefire/pull/114#issuecomment-300371834>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_yR079Y1Bk-3NkdWMgpkLDtNtWpvu9ks5r4T_AgaJpZM4JKVF6>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
ParallelComputerBuilder.PC sets scheduller to runner (see org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder.PC#setSchedulers(org.junit.runners.ParentRunner, org.junit.runners.ParentRunner)
Spock just schedule test methods to provided Scheduller.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
"Master Origin" integration tests suite does not pass on my Windows box.
```
Results :
Failed tests: properNewlinesAndEncodingWithDifferentEncoding(org.apache.maven.surefire.its.ConsoleOutputIT): Did not find ex pected message in log
properNewlinesAndEncodingWithDefaultEncodings(org.apache.maven.surefire.its.ConsoleOutputIT): Did not find expected message in log
properNewlinesAndEncodingWithoutFork(org.apache.maven.surefire.its.ConsoleOutputIT): Did not find expected message in log
Tests in error:
testUmlautIsolatedClassLoader(org.apache.maven.surefire.its.UmlautDirIT): Exit code was non-zero: 1; command line and log = (..)
testUmlaut(org.apache.maven.surefire.its.UmlautDirIT): Exit code was non-zero: 1; command line and log = (..)
```
But this PR does nothing with encodings, I think we can ignore this errors now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by szpak <gi...@git.apache.org>.
Github user szpak commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Is there a plan to make it merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Thank you.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Fuud <gi...@git.apache.org>.
Github user Fuud commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Because Spock can't (do not want) generate runners at test object creation time. Parametrized runners are generated at runtime and therefore not known at init time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
hm, I am not sure creating runners is possible and even if it is how this
could work with us because we create JUnitCore instance and put PC in to if
and intercept JUnit builder and handle all runners before runtime.
If you say you create runners at runtime means that Junit must know it and
PC would not.
On Fri, May 5, 2017 at 12:54 PM, Fedor Bobin <no...@github.com>
wrote:
> Because Spock can't (do not want) generate runners at test object creation
> time. Parametrized runners are generated at runtime and therefore not known
> at init time.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-surefire/pull/114#issuecomment-299436059>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_yRzpZrl4KiPigI_QNdcRzWES0k8_Qks5r2v_YgaJpZM4JKVF6>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org