You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhan7236 (via GitHub)" <gi...@apache.org> on 2025/11/30 17:55:53 UTC
[PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
zhan7236 opened a new pull request, #58539:
URL: https://github.com/apache/doris/pull/58539
### What problem does this PR solve?
- **Issue Number**: close #58199 (partial)
- **Related PR**: N/A
**Problem Summary:**
This PR implements the `ancestors_of` procedure for Iceberg tables. The procedure reports the live snapshot IDs and timestamps of the ancestors of a specified snapshot, helping users trace snapshot lineage and understand the commit history of a table.
**Syntax:**
```sql
ALTER TABLE catalog.db.table_name EXECUTE ancestors_of();
ALTER TABLE catalog.db.table_name EXECUTE ancestors_of("snapshot_id" = "123456789");
```
**Output:**
Returns `snapshot_id` (BIGINT) and `timestamp` (BIGINT) for each ancestor snapshot.
**Use cases:**
- Locate rollback targets
- Debug commit relationships
- Understand table evolution history
### Release note
Support `ancestors_of` procedure for Iceberg tables to report snapshot ancestry chain.
### Check List (For Author)
**Test**
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
**Behavior changed:**
- [x] No.
- [ ] Yes.
**Does this need documentation?**
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #58539:
URL: https://github.com/apache/doris/pull/58539#issuecomment-3609800527
It looks like there are compilation errors.
http://43.132.222.7:8111/buildConfiguration/Doris_DorisCompile_Compile/849991?buildTab=log&linesState=191&logView=flowAware&focusLine=12350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #58539:
URL: https://github.com/apache/doris/pull/58539#issuecomment-3605370309
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58539:
URL: https://github.com/apache/doris/pull/58539#issuecomment-4747317039
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #58539:
URL: https://github.com/apache/doris/pull/58539#issuecomment-3605475593
It looks like there are compilation errors.
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project fe-core: Compilation failure
[15:22:47 ](http://43.132.222.7:8111/buildConfiguration/Doris_Doris_FeUt/849698?buildTab=log&linesState=51181&logView=flowAware&focusLine=51181) [ERROR] /root/doris/fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/action/IcebergAncestorsOfAction.java:[98,22] execute(org.apache.doris.catalog.TableIf) in org.apache.doris.datasource.iceberg.action.IcebergAncestorsOfAction cannot override execute(org.apache.doris.catalog.TableIf) in org.apache.doris.nereids.trees.plans.commands.execute.BaseExecuteAction
[15:22:47 ](http://43.132.222.7:8111/buildConfiguration/Doris_Doris_FeUt/849698?buildTab=log&linesState=51182&logView=flowAware&focusLine=51182) [ERROR] overridden method is final
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #58539:
URL: https://github.com/apache/doris/pull/58539#issuecomment-3659424753
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #58539:
URL: https://github.com/apache/doris/pull/58539#issuecomment-3605365217
Thank you for your contribution🚀. I will review the code immediately. PS: Please revise the description and do not close this issue https://github.com/apache/doris/issues/58199, as it is a tracked issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #58539:
URL: https://github.com/apache/doris/pull/58539#issuecomment-3646150369
@zhan7236 Hi, if you need further support and assistance regarding the Doris open-source project, you can try contacting me. This is my WeChat ID: suyiteng123.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #58539:
URL: https://github.com/apache/doris/pull/58539#issuecomment-3592965558
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](Iceberg) Implement ancestors_of procedure for Iceberg tables [doris]
Posted by "zhan7236 (via GitHub)" <gi...@apache.org>.
zhan7236 commented on PR #58539:
URL: https://github.com/apache/doris/pull/58539#issuecomment-3592971303
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org