You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/01 21:17:29 UTC

[GitHub] [beam] youngoli commented on a change in pull request #11257: [BEAM-9642] Create runtime invokers for SDF methods.

youngoli commented on a change in pull request #11257: [BEAM-9642] Create runtime invokers for SDF methods.
URL: https://github.com/apache/beam/pull/11257#discussion_r401914972
 
 

 ##########
 File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers.go
 ##########
 @@ -23,29 +23,36 @@ import (
 	"reflect"
 )
 
-func invokeCreateInitialRestriction(fn *funcx.Fn, elms *FullValue) (rest interface{}, err error) {
+func createInitialRestrictionCallFn(fn *funcx.Fn) (callFn func(*FullValue) interface{}, err error) {
 
 Review comment:
   It's actually returning a func (which returns an interface{}), and an error. I can see the confusion though, might be worth wrapping the return value in parentheses just for clarity.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services