You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@libcloud.apache.org by "Aymeric Barantal (Created) (JIRA)" <ji...@apache.org> on 2011/09/27 14:16:11 UTC
[dev] [jira] [Created] (LIBCLOUD-115) Add some extra methods in gandi
driver
Add some extra methods in gandi driver
--------------------------------------
Key: LIBCLOUD-115
URL: https://issues.apache.org/jira/browse/LIBCLOUD-115
Project: Libcloud
Issue Type: Improvement
Components: Compute
Affects Versions: 0.5.2
Reporter: Aymeric Barantal
Priority: Minor
Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)
Methods implemented are :
ex_list_disks
ex_node_attach_disk and ex_node_detach_disk
ex_snapshot_disk
ex_update_disk
ex_list_interfaces
ex_node_attach_interface and ex_node_detach_interface
Full test coverage for these methods included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Resolved] (LIBCLOUD-115) Add some extra methods in gandi
driver
Posted by "Tomaz Muraus (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomaz Muraus resolved LIBCLOUD-115.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.6.0
> Add some extra methods in gandi driver
> --------------------------------------
>
> Key: LIBCLOUD-115
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-115
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.5.2
> Reporter: Aymeric Barantal
> Priority: Minor
> Fix For: 0.6.0
>
> Attachments: 0001-pep8-compliance.patch, 0002-gandi-base-driver-in-common.patch, 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch, 0004-pep8-in-test_gandi.patch, 0005-simple-test-for-ex_-methods.patch, 0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch, 0007-snapshot-name-must-be-len-15.patch
>
>
> Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)
> Methods implemented are :
> ex_list_disks
> ex_node_attach_disk and ex_node_detach_disk
> ex_snapshot_disk
> ex_update_disk
> ex_list_interfaces
> ex_node_attach_interface and ex_node_detach_interface
> Full test coverage for these methods included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Updated] (LIBCLOUD-115) Add some extra methods in gandi
driver
Posted by "Aymeric Barantal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aymeric Barantal updated LIBCLOUD-115:
--------------------------------------
Attachment: 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch
> Add some extra methods in gandi driver
> --------------------------------------
>
> Key: LIBCLOUD-115
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-115
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.5.2
> Reporter: Aymeric Barantal
> Priority: Minor
> Attachments: 0001-pep8-compliance.patch, 0002-gandi-base-driver-in-common.patch, 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch, 0004-pep8-in-test_gandi.patch, 0005-simple-test-for-ex_-methods.patch, 0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch, 0007-snapshot-name-must-be-len-15.patch
>
>
> Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)
> Methods implemented are :
> ex_list_disks
> ex_node_attach_disk and ex_node_detach_disk
> ex_snapshot_disk
> ex_update_disk
> ex_list_interfaces
> ex_node_attach_interface and ex_node_detach_interface
> Full test coverage for these methods included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Commented] (LIBCLOUD-115) Add some extra methods in gandi
driver
Posted by "Tomaz Muraus (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115903#comment-13115903 ]
Tomaz Muraus commented on LIBCLOUD-115:
---------------------------------------
I just checked the patches and here are some of the things I have noticed:
- if other drivers, not just the compute one will inherit from the BaseGandiDriver class, then you should only leave the common class attributes there.
api_name is at the moment compute specific and the type constant is also usually different across the APIs.
0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch
- for ip in iface.get('ips') should be for ip in iface.get('ips', [])
- tests look in general, but adding some more tests for edge conditions wouldn't hurt :)
Thanks
> Add some extra methods in gandi driver
> --------------------------------------
>
> Key: LIBCLOUD-115
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-115
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.5.2
> Reporter: Aymeric Barantal
> Priority: Minor
> Attachments: 0001-pep8-compliance.patch, 0002-gandi-base-driver-in-common.patch, 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch, 0004-pep8-in-test_gandi.patch, 0005-simple-test-for-ex_-methods.patch, 0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch, 0007-snapshot-name-must-be-len-15.patch
>
>
> Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)
> Methods implemented are :
> ex_list_disks
> ex_node_attach_disk and ex_node_detach_disk
> ex_snapshot_disk
> ex_update_disk
> ex_list_interfaces
> ex_node_attach_interface and ex_node_detach_interface
> Full test coverage for these methods included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Commented] (LIBCLOUD-115) Add some extra methods in gandi
driver
Posted by "Aymeric Barantal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116329#comment-13116329 ]
Aymeric Barantal commented on LIBCLOUD-115:
-------------------------------------------
I provided another pull request on a specific branch as you'd request : https://github.com/apache/libcloud/pull/30. Updates based on your comment on previous request are included.
> Add some extra methods in gandi driver
> --------------------------------------
>
> Key: LIBCLOUD-115
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-115
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.5.2
> Reporter: Aymeric Barantal
> Priority: Minor
> Attachments: 0001-pep8-compliance.patch, 0002-gandi-base-driver-in-common.patch, 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch, 0004-pep8-in-test_gandi.patch, 0005-simple-test-for-ex_-methods.patch, 0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch, 0007-snapshot-name-must-be-len-15.patch
>
>
> Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)
> Methods implemented are :
> ex_list_disks
> ex_node_attach_disk and ex_node_detach_disk
> ex_snapshot_disk
> ex_update_disk
> ex_list_interfaces
> ex_node_attach_interface and ex_node_detach_interface
> Full test coverage for these methods included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Commented] (LIBCLOUD-115) Add some extra methods in gandi
driver
Posted by "Tomaz Muraus (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116306#comment-13116306 ]
Tomaz Muraus commented on LIBCLOUD-115:
---------------------------------------
OK, now I also added some comments to the diff in your pull request - https://github.com/apache/libcloud/pull/29
> Add some extra methods in gandi driver
> --------------------------------------
>
> Key: LIBCLOUD-115
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-115
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.5.2
> Reporter: Aymeric Barantal
> Priority: Minor
> Attachments: 0001-pep8-compliance.patch, 0002-gandi-base-driver-in-common.patch, 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch, 0004-pep8-in-test_gandi.patch, 0005-simple-test-for-ex_-methods.patch, 0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch, 0007-snapshot-name-must-be-len-15.patch
>
>
> Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)
> Methods implemented are :
> ex_list_disks
> ex_node_attach_disk and ex_node_detach_disk
> ex_snapshot_disk
> ex_update_disk
> ex_list_interfaces
> ex_node_attach_interface and ex_node_detach_interface
> Full test coverage for these methods included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Updated] (LIBCLOUD-115) Add some extra methods in gandi
driver
Posted by "Aymeric Barantal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aymeric Barantal updated LIBCLOUD-115:
--------------------------------------
Attachment: 0007-snapshot-name-must-be-len-15.patch
0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch
0005-simple-test-for-ex_-methods.patch
0004-pep8-in-test_gandi.patch
> Add some extra methods in gandi driver
> --------------------------------------
>
> Key: LIBCLOUD-115
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-115
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.5.2
> Reporter: Aymeric Barantal
> Priority: Minor
> Attachments: 0001-pep8-compliance.patch, 0002-gandi-base-driver-in-common.patch, 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch, 0004-pep8-in-test_gandi.patch, 0005-simple-test-for-ex_-methods.patch, 0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch, 0007-snapshot-name-must-be-len-15.patch
>
>
> Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)
> Methods implemented are :
> ex_list_disks
> ex_node_attach_disk and ex_node_detach_disk
> ex_snapshot_disk
> ex_update_disk
> ex_list_interfaces
> ex_node_attach_interface and ex_node_detach_interface
> Full test coverage for these methods included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Updated] (LIBCLOUD-115) Add some extra methods in gandi
driver
Posted by "Aymeric Barantal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aymeric Barantal updated LIBCLOUD-115:
--------------------------------------
Attachment: 0002-gandi-base-driver-in-common.patch
> Add some extra methods in gandi driver
> --------------------------------------
>
> Key: LIBCLOUD-115
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-115
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.5.2
> Reporter: Aymeric Barantal
> Priority: Minor
> Attachments: 0001-pep8-compliance.patch, 0002-gandi-base-driver-in-common.patch, 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch, 0004-pep8-in-test_gandi.patch, 0005-simple-test-for-ex_-methods.patch, 0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch, 0007-snapshot-name-must-be-len-15.patch
>
>
> Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)
> Methods implemented are :
> ex_list_disks
> ex_node_attach_disk and ex_node_detach_disk
> ex_snapshot_disk
> ex_update_disk
> ex_list_interfaces
> ex_node_attach_interface and ex_node_detach_interface
> Full test coverage for these methods included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[dev] [jira] [Updated] (LIBCLOUD-115) Add some extra methods in gandi
driver
Posted by "Aymeric Barantal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LIBCLOUD-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aymeric Barantal updated LIBCLOUD-115:
--------------------------------------
Attachment: 0001-pep8-compliance.patch
> Add some extra methods in gandi driver
> --------------------------------------
>
> Key: LIBCLOUD-115
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-115
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.5.2
> Reporter: Aymeric Barantal
> Priority: Minor
> Attachments: 0001-pep8-compliance.patch, 0002-gandi-base-driver-in-common.patch, 0003-ex_-methods-ex_list_interfaces-ex_list_disk-ex_attac.patch, 0004-pep8-in-test_gandi.patch, 0005-simple-test-for-ex_-methods.patch, 0006-add-snapshot_disk-and-update_disk-ex-methods.-Change.patch, 0007-snapshot-name-must-be-len-15.patch
>
>
> Here some improvements to gandi compute driver. Base class for connnection and driver had been move in common package to prepare for other driver than compute one (dns for ex)
> Methods implemented are :
> ex_list_disks
> ex_node_attach_disk and ex_node_detach_disk
> ex_snapshot_disk
> ex_update_disk
> ex_list_interfaces
> ex_node_attach_interface and ex_node_detach_interface
> Full test coverage for these methods included.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira