[GitHub] [pinot] walterddr commented on a diff in pull request #10797: [multistage][bugfix] fix singleton exchange

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10797:
URL: https://github.com/apache/pinot/pull/10797#discussion_r1202729305


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/SingletonExchange.java:
##########
@@ -41,7 +42,13 @@ class SingletonExchange extends BlockExchange {
   protected void route(List<SendingMailbox> mailbox, TransferableBlock block)
       throws Exception {
     for (SendingMailbox sendingMailbox : mailbox) {
-      sendBlock(sendingMailbox, block);
+      if (isLocal(sendingMailbox)) {

Review Comment:
   TODO for this PR
   - Throw when 0, or more than 1 exchange is configured ( test on block exchange unit test)
   - Do not allow this ok worker assignment strategy  in the first place 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org