You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2005/05/27 20:34:49 UTC

Re: svn commit: r14866 - trunk/subversion/svnlook

lundblad@tigris.org writes:
> --- trunk/subversion/svnlook/main.c	(original)
> +++ trunk/subversion/svnlook/main.c	Fri May 27 15:49:33 2005
> @@ -539,6 +539,9 @@
>  }
>  
>  
> +/* Open PATH as an empty writable binary file, creating it if it doesn't exist.
> +   Create ancestor directories if necessary.
> +   Use POOL for temporary allocations. */
>  static svn_error_t *
>  open_writable_binary_file (apr_file_t **fh, 
>                             const char *path /* UTF-8! */, 

Mention all parameters.  Also, pool isn't just for temporary
allocation, is it?

   "Set *FH to a file handle for a writeable binary file at PATH.
    Create the file if it doesn't exist, truncate it if it does.
    Create ancestor directories if necessary.  Allocate *FH in POOL."

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r14866 - trunk/subversion/svnlook

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Fri, 27 May 2005 kfogel@collab.net wrote:

> Mention all parameters.  Also, pool isn't just for temporary
> allocation, is it?
>
Ouch! Sorry! Fixed.

/me throws big stones on myself.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org