You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 16:21:42 UTC

[GitHub] [arrow-rs] ritchie46 commented on pull request #318: Mutablebuffer::shrink_to_fit

ritchie46 commented on pull request #318:
URL: https://github.com/apache/arrow-rs/pull/318#issuecomment-843320071


   > Could we add a test? ^_^
   
   Definitely! It was already in the docstring, but I will add an explicit one.
   
   > I am not sure we need inline this; inlining is useful when growing because it is used over an iterator with push; I am not sure it is needed for shrinking
   
   I agree. :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org