You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/22 13:05:14 UTC
[GitHub] [airflow] ashb opened a new pull request #21734: Upgrade and record elasticsearch log_id_template changes
ashb opened a new pull request #21734:
URL: https://github.com/apache/airflow/pull/21734
As part of making this change I also reworked the synchronize_log_template to not continually create pairs of (upgraded,
new) rows when the old template was in the config file but upgraded in place (as spotted by @dstandish )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #21734: Upgrade and record elasticsearch log_id_template changes
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #21734:
URL: https://github.com/apache/airflow/pull/21734#discussion_r812048063
##########
File path: airflow/configuration.py
##########
@@ -211,6 +211,13 @@ class AirflowConfigParser(ConfigParser):
3.0,
),
},
+ 'elasticsearch': {
Review comment:
We should probably add this to `UPDATING.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #21734: Upgrade and record elasticsearch log_id_template changes
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #21734:
URL: https://github.com/apache/airflow/pull/21734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #21734: Upgrade and record elasticsearch log_id_template changes
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #21734:
URL: https://github.com/apache/airflow/pull/21734#discussion_r812074227
##########
File path: airflow/configuration.py
##########
@@ -211,6 +211,13 @@ class AirflowConfigParser(ConfigParser):
3.0,
),
},
+ 'elasticsearch': {
Review comment:
Whops, we never added a similar message for log_filename_template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21734: Upgrade and record elasticsearch log_id_template changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21734:
URL: https://github.com/apache/airflow/pull/21734#issuecomment-1049831654
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #21734: Upgrade and record elasticsearch log_id_template changes
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #21734:
URL: https://github.com/apache/airflow/pull/21734#discussion_r813797669
##########
File path: airflow/configuration.py
##########
@@ -211,6 +211,13 @@ class AirflowConfigParser(ConfigParser):
3.0,
),
},
+ 'elasticsearch': {
Review comment:
Done (for both) in 88ee4dfe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org