[GitHub] [tez] abstractdog commented on a diff in pull request #150: TEZ-4334: Resolve deadlock in ShuffleScheduler which occurs when ShufflePenaltyReferee waits for the lock of ShuffleScheduler

["abstractdog (via GitHub)" <gi...@apache.org>]

abstractdog commented on code in PR #150:
URL: https://github.com/apache/tez/pull/150#discussion_r1124331698


##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/ShuffleScheduler.java:
##########
@@ -1015,51 +1019,63 @@ boolean isShuffleHealthy(InputAttemptIdentifier srcAttempt) {
     final float MIN_REQUIRED_PROGRESS_PERCENT = minReqProgressFraction;
     final float MAX_ALLOWED_STALL_TIME_PERCENT = maxStallTimeFraction;
 
-    int doneMaps = numInputs - remainingMaps.get();
+    String errorMsg = null;

Review Comment:
   yeah, the original goal has already been achieved I guess
   what I really meant was to make a simple refactor in the very same codepath without making the patch bigger, please refer to https://github.com/apache/tez/pull/273
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org