You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/15 16:31:05 UTC
[GitHub] [arrow] paleolimbot opened a new pull request, #14647: ARROW-18321: [R] Add tests for binary_slice kernel
paleolimbot opened a new pull request, #14647:
URL: https://github.com/apache/arrow/pull/14647
This PR adds a test for the kernel implemented in ARROW-17301 (#14550).
Are there any R functions that map to this? (i.e., is there any `register_binding()` we should do for an R function?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14647: ARROW-18321: [R] Add tests for binary_slice kernel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14647:
URL: https://github.com/apache/arrow/pull/14647#issuecomment-1315566622
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #14647: ARROW-18321: [R] Add tests for binary_slice kernel
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #14647:
URL: https://github.com/apache/arrow/pull/14647#issuecomment-1315636721
We already do `substr()` (which maps to the `utf8_slice_codeunits()` function...this doesn't work on a string type).
Fun discovery in the process, though:
``` r
substr(list(as.raw(1:5)), 1, 100)
#> [1] "as.raw(c(0x01, 0x02, 0x03, 0x04, 0x05))"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #14647: ARROW-18321: [R] Add tests for binary_slice kernel
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #14647:
URL: https://github.com/apache/arrow/pull/14647#issuecomment-1315606599
> Are there any R functions that map to this? (i.e., is there any `register_binding()` we should do for an R function?)
`substr()`? Assuming this also works on `string()` type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #14647: ARROW-18321: [R] Add tests for binary_slice kernel
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #14647:
URL: https://github.com/apache/arrow/pull/14647#issuecomment-1317136099
> Would it make sense to call binary_slice inside of substr() if the type of the input is binary()?
Seemed easy enough!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14647: ARROW-18321: [R] Add tests for binary_slice kernel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14647:
URL: https://github.com/apache/arrow/pull/14647#issuecomment-1315566580
https://issues.apache.org/jira/browse/ARROW-18321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #14647: ARROW-18321: [R] Add tests for binary_slice kernel
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #14647:
URL: https://github.com/apache/arrow/pull/14647#issuecomment-1315747284
> We already do `substr()` (which maps to the `utf8_slice_codeunits()` function...this doesn't work on a string type).
>
Ah ok. Would it make sense to call `binary_slice` inside of `substr()` if the type of the input is `binary()`? Or maybe it's not worth bothering with.
> Fun discovery in the process, though:
>
> ```r
> substr(list(as.raw(1:5)), 1, 100)
> #> [1] "as.raw(c(0x01, 0x02, 0x03, 0x04, 0x05))"
> ```
Yeah that is truly odd. Without `list()` it is more sensible.
```
> as.character(list(as.raw(1:5)))
[1] "as.raw(c(0x01, 0x02, 0x03, 0x04, 0x05))"
> as.character(as.raw(1:5))
[1] "01" "02" "03" "04" "05"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot merged pull request #14647: ARROW-18321: [R] Add tests for binary_slice kernel
Posted by GitBox <gi...@apache.org>.
paleolimbot merged PR #14647:
URL: https://github.com/apache/arrow/pull/14647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14647: ARROW-18321: [R] Add tests for binary_slice kernel
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14647:
URL: https://github.com/apache/arrow/pull/14647#issuecomment-1318331734
Benchmark runs are scheduled for baseline = e38141421d43d0ae57bae083e15c1f8264a9850a and contender = 5f8cc745b1fe11acf4ef3d508efc2ff7558894d6. 5f8cc745b1fe11acf4ef3d508efc2ff7558894d6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ceeba7d9e26446c5a286285eb57c0422...154cf040775a437092db4ce6cf0cd778/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/283ce12da2604c73a239cf372ed1f6e9...1abbf4d35e3b4765b96354a0b07c5f3b/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2d69a454d46f458f9a13b129938b7331...965e516e53cd46beb0ad92444cf1aaca/)
[Finished :arrow_down:0.35% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/44a41e28bbfd462890d3bb0a660fdf14...0049d3eadaf6482b9d5d72a5026ac989/)
Buildkite builds:
[Finished] [`5f8cc745` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1883)
[Finished] [`5f8cc745` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1905)
[Failed] [`5f8cc745` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1874)
[Finished] [`5f8cc745` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1897)
[Finished] [`e3814142` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1882)
[Finished] [`e3814142` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1904)
[Finished] [`e3814142` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1873)
[Finished] [`e3814142` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1896)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org