You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by candeira <gi...@git.apache.org> on 2015/01/06 06:02:54 UTC
[GitHub] couchdb pull request: Fix Makefile, finish separation of CouchDB/F...
GitHub user candeira opened a pull request:
https://github.com/apache/couchdb/pull/293
Fix Makefile, finish separation of CouchDB/Fauxton compilation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/candeira/couchdb fix_makefile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit 8b2d6884d364288f0d194e83fd501d19cbde4407
Author: Javier Candeira <ja...@candeira.com>
Date: 2015-01-06T04:45:30Z
Fix Makefile, finish separation of CouchDB/Fauxton compilation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix Makefile, finish separation of CouchDB/F...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/293#issuecomment-69664276
Landed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix Makefile, finish separation of CouchDB/F...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb/pull/293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix Makefile, finish separation of CouchDB/F...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/293#issuecomment-69716753
There isn't. There is no need to produce merges on master branch for small fixes. It's makes a sense when it is release branch or you develop some feature with many commits, so merge makes easily to track the from where the changes came from.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix Makefile, finish separation of CouchDB/F...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/293#issuecomment-68826842
`javascript` target still depends on `compile`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix Makefile, finish separation of CouchDB/F...
Posted by candeira <gi...@git.apache.org>.
Github user candeira commented on the pull request:
https://github.com/apache/couchdb/pull/293#issuecomment-68959830
Groan. You're right. Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix Makefile, finish separation of CouchDB/F...
Posted by candeira <gi...@git.apache.org>.
Github user candeira commented on the pull request:
https://github.com/apache/couchdb/pull/293#issuecomment-69714762
Hi @kxepal, I'm guessing that github says "Closed with unmerged commmits" because you picked the PR directly from the ASF git repo. Where is that workflow documented?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---