[GitHub] [james-project] chibenwa commented on a change in pull request #358: [REFACTORING] JMAP: All ids should be backed by IdConstraint

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #358:
URL: https://github.com/apache/james-project/pull/358#discussion_r606941993



##########
File path: server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/VacationResponseGetMethodContract.scala
##########
@@ -482,14 +482,16 @@ trait VacationResponseGetMethodContract {
       .asString
       .stripMargin
 
-    assertThatJson(response).isEqualTo(
+    assertThatJson(response)
+      .whenIgnoringPaths("methodResponses[0][1].description")

Review comment:
       Honestly I gave up trying to understand the escape sequence after 1 hour +.
   
   (a Json in a JSON in a scala string).
   
   I see little value in spending my time doing it.
   
   If you wonna give it a shot though, contribs are welcome.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org