[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18121: [feat][client] Add ClientConfiguration options for in memory TLS certs

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #18121:
URL: https://github.com/apache/pulsar/pull/18121#discussion_r999861935


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java:
##########
@@ -162,6 +165,24 @@ public class ClientConfigurationData implements Serializable, Cloneable {
     )
     private String tlsTrustCertsFilePath = null;
 
+    @ApiModelProperty(
+            name = "tlsPrivateKey",
+            value = "The private key for the client certificate. Only used when tlsTrustStoreStream is non-null."
+    )
+    private PrivateKey tlsPrivateKey = null;

Review Comment:
   Great question. I was just noticing that the regular configuration does not allow for renewing the key, which is likely a missing feature. I was about to change my implementation to match this class: https://github.com/apache/pulsar/blob/330fcb9787d9f822667f0617b22bcae66b4644e5/pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationDataTls.java#L69-L85
   
   However, that might not work either.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org