[GitHub] [druid] suneet-s commented on a change in pull request #10761: Fix kinesis ingestion bugs

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #10761:
URL: https://github.com/apache/druid/pull/10761#discussion_r558538468



##########
File path: services/src/main/java/org/apache/druid/cli/PullDependencies.java
##########
@@ -83,6 +83,9 @@
                   .put("commons-beanutils", "commons-beanutils")
                   .put("org.apache.commons", "commons-compress")
                   .put("org.apache.zookeeper", "zookeeper")
+                  .put("com.fasterxml.jackson.core", "jackson-databind")
+                  .put("com.fasterxml.jackson.core", "jackson-core")
+                  .put("com.fasterxml.jackson.core", "jackson-annotations")

Review comment:
       I assume this is the part of the PR that fixes
   
   ```
   When druid.extensions.useExtensionClassloaderFirst is set to true, services fail to start due to duplicate jackson-databind dependencies in extensions.
   ```
   Can you explain how? I don't understand PullDependencies well enough




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org