You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/10 10:57:30 UTC

[GitHub] [incubator-tvm] t-vi opened a new pull request #6440: [ROCm] include mcpu and mtriple as target options

t-vi opened a new pull request #6440:
URL: https://github.com/apache/incubator-tvm/pull/6440


   This fixes the ROCm backend after #6347 to also allow mcpu and mtriple attributes for ROCm target objects.
   
   With this change, we can run the gpu_imagenet_bench.py again.
   
   @junrushao1994 @masahi 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] t-vi commented on pull request #6440: [ROCm] include mcpu and mtriple as target options

Posted by GitBox <gi...@apache.org>.
t-vi commented on pull request #6440:
URL: https://github.com/apache/incubator-tvm/pull/6440#issuecomment-690536150


   @junrushao1994 Right, thank you! @masahi @tqchen sorry for the noise. I had searched for rocm/mcpu patches but missed the more general one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] t-vi closed pull request #6440: [ROCm] include mcpu and mtriple as target options

Posted by GitBox <gi...@apache.org>.
t-vi closed pull request #6440:
URL: https://github.com/apache/incubator-tvm/pull/6440


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6440: [ROCm] include mcpu and mtriple as target options

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6440:
URL: https://github.com/apache/incubator-tvm/pull/6440#issuecomment-690464393


   Hmmm I think the issue has been fixed by #6369


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on pull request #6440: [ROCm] include mcpu and mtriple as target options

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6440:
URL: https://github.com/apache/incubator-tvm/pull/6440#issuecomment-690456262


   @t-vi please rebase against the master to resolve conflicts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] masahi commented on pull request #6440: [ROCm] include mcpu and mtriple as target options

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #6440:
URL: https://github.com/apache/incubator-tvm/pull/6440#issuecomment-690208719


   Nice, just today I did a clean install of rocm 3.7, and wondered why the benchmark is broken. So timely for me :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org