You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Kevin Ballard (JIRA)" <ji...@apache.org> on 2008/07/25 22:13:31 UTC
[jira] Created: (THRIFT-97) BinaryProtocolAccelerated does not
encode strings with null bytes properly
BinaryProtocolAccelerated does not encode strings with null bytes properly
--------------------------------------------------------------------------
Key: THRIFT-97
URL: https://issues.apache.org/jira/browse/THRIFT-97
Project: Thrift
Issue Type: Bug
Components: Library (Ruby)
Reporter: Kevin Ballard
Attachments: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
BinaryProtocolAccelerated will stop encoding a string when it contains null bytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-97) BinaryProtocolAccelerated does not
encode strings with null bytes properly
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617043#action_12617043 ]
Kevin Clark commented on THRIFT-97:
-----------------------------------
This looks good to me, but I'm on vacation and away from a computer that I can push from. Could someone commit this for me?
> BinaryProtocolAccelerated does not encode strings with null bytes properly
> --------------------------------------------------------------------------
>
> Key: THRIFT-97
> URL: https://issues.apache.org/jira/browse/THRIFT-97
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Ballard
> Priority: Critical
> Attachments: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
>
>
> BinaryProtocolAccelerated will stop encoding a string when it contains null bytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-97) BinaryProtocolAccelerated does not
encode strings with null bytes properly
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-97:
--------------------------------
Priority: Critical (was: Major)
> BinaryProtocolAccelerated does not encode strings with null bytes properly
> --------------------------------------------------------------------------
>
> Key: THRIFT-97
> URL: https://issues.apache.org/jira/browse/THRIFT-97
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Ballard
> Priority: Critical
> Attachments: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
>
>
> BinaryProtocolAccelerated will stop encoding a string when it contains null bytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-97) BinaryProtocolAccelerated does not
encode strings with null bytes properly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-97:
-----------------------------------
Assignee: Kevin Ballard
> BinaryProtocolAccelerated does not encode strings with null bytes properly
> --------------------------------------------------------------------------
>
> Key: THRIFT-97
> URL: https://issues.apache.org/jira/browse/THRIFT-97
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Ballard
> Assignee: Kevin Ballard
> Priority: Critical
> Attachments: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
>
>
> BinaryProtocolAccelerated will stop encoding a string when it contains null bytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-97) BinaryProtocolAccelerated does not
encode strings with null bytes properly
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Clark closed THRIFT-97.
-----------------------------
Resolution: Fixed
In 679899
> BinaryProtocolAccelerated does not encode strings with null bytes properly
> --------------------------------------------------------------------------
>
> Key: THRIFT-97
> URL: https://issues.apache.org/jira/browse/THRIFT-97
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Ballard
> Priority: Critical
> Attachments: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
>
>
> BinaryProtocolAccelerated will stop encoding a string when it contains null bytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-97) BinaryProtocolAccelerated does not
encode strings with null bytes properly
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617047#action_12617047 ]
David Reiss commented on THRIFT-97:
-----------------------------------
lib/rb/spec/binaryprotocolaccelerated_spec.rb doesn't appear to be in svn. Does this depend on an earlier issue?
> BinaryProtocolAccelerated does not encode strings with null bytes properly
> --------------------------------------------------------------------------
>
> Key: THRIFT-97
> URL: https://issues.apache.org/jira/browse/THRIFT-97
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Ballard
> Priority: Critical
> Attachments: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
>
>
> BinaryProtocolAccelerated will stop encoding a string when it contains null bytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-97) BinaryProtocolAccelerated does not
encode strings with null bytes properly
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617050#action_12617050 ]
Kevin Clark commented on THRIFT-97:
-----------------------------------
89 and 90 look fine.
> BinaryProtocolAccelerated does not encode strings with null bytes properly
> --------------------------------------------------------------------------
>
> Key: THRIFT-97
> URL: https://issues.apache.org/jira/browse/THRIFT-97
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Ballard
> Priority: Critical
> Attachments: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
>
>
> BinaryProtocolAccelerated will stop encoding a string when it contains null bytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-97) BinaryProtocolAccelerated does not
encode strings with null bytes properly
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-97:
--------------------------------
Attachment: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
> BinaryProtocolAccelerated does not encode strings with null bytes properly
> --------------------------------------------------------------------------
>
> Key: THRIFT-97
> URL: https://issues.apache.org/jira/browse/THRIFT-97
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Ballard
> Attachments: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
>
>
> BinaryProtocolAccelerated will stop encoding a string when it contains null bytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-97) BinaryProtocolAccelerated does not
encode strings with null bytes properly
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617049#action_12617049 ]
Kevin Ballard commented on THRIFT-97:
-------------------------------------
Yeah, it depends on THRIFT-90, which has been sitting in the review queue for about 1.5 weeks. And as long as we're talking about BinaryProtocolAccelerated, someone should take a look at THRIFT-89.
> BinaryProtocolAccelerated does not encode strings with null bytes properly
> --------------------------------------------------------------------------
>
> Key: THRIFT-97
> URL: https://issues.apache.org/jira/browse/THRIFT-97
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Ballard
> Priority: Critical
> Attachments: 0001-rb-Teach-BinaryProtocolAccelerated-to-encode-string.patch
>
>
> BinaryProtocolAccelerated will stop encoding a string when it contains null bytes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.