[GitHub] [doris] morrySnow commented on a diff in pull request #15983: [fix](Nereids): add integer type and fix bug in nsl join

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #15983:
URL: https://github.com/apache/doris/pull/15983#discussion_r1071478807


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1025,7 +1025,7 @@ public PlanFragment visitPhysicalNestedLoopJoin(
             leftFragment.setPlanRoot(nestedLoopJoinNode);
             List<Expr> joinConjuncts = nestedLoopJoin.getOtherJoinConjuncts().stream()
                     .map(e -> ExpressionTranslator.translate(e, context)).collect(Collectors.toList());
-            nestedLoopJoinNode.setJoinConjuncts(joinConjuncts);
+            nestedLoopJoinNode.addConjuncts(joinConjuncts);

Review Comment:
   why we put join conjuncts to filter? i don't think it is right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org