[jira] [Commented] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190966#comment-16190966 ] 

ASF GitHub Bot commented on FLINK-7758:
---------------------------------------

GitHub user yew1eb opened a pull request:

    https://github.com/apache/flink/pull/4769

    [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add kafkaMetricGroup

    ## What is the purpose of the change
    
    *Fix bug Kafka09Fetcher no judge the useMetrics is true when add kafkaMetricGroup*
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as *KafkaConsumerThreadTest, Kafka09FetcherTest, Kafka10FetcherTest*.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yew1eb/flink FLINK-7758

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4769.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4769
    
----
commit 6c4faaa99832ec01123d83d0e885c0d1d9cc67c7
Author: yew1eb <ye...@gmail.com>
Date:   2017-10-04T07:51:05Z

    fix bug no judge the useMetrics is true when add kafkaMetricGroup

----


> Fix bug  Kafka09Fetcher add offset metrics 
> -------------------------------------------
>
>                 Key: FLINK-7758
>                 URL: https://issues.apache.org/jira/browse/FLINK-7758
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.3.2
>            Reporter: Hai Zhou UTC+8
>            Assignee: Hai Zhou UTC+8
>             Fix For: 1.4.0
>
>
> in Kafka09Fetcher, add _KafkaConsumer_ kafkaMetricGroup. 
> No judgment that the useMetrics variable is true.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)