You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/26 08:53:59 UTC

[GitHub] [dolphinscheduler] Radeity opened a new pull request, #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Radeity opened a new pull request, #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   ## Purpose of the pull request
   - close https://github.com/apache/dolphinscheduler/issues/12960
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   - Target version: 2.0.x
   - Simply synchronize change from https://github.com/apache/dolphinscheduler/pull/9952 and https://github.com/apache/dolphinscheduler/pull/9730.
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   (or)
   
   If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] JinyLeeChina merged pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
JinyLeeChina merged PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] JinyLeeChina commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1364629272

   Good job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] JinyLeeChina commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1357236468

   <img width="745" alt="image" src="https://user-images.githubusercontent.com/42576980/208375851-b4ec447a-48d0-4eac-a6a9-cfcd81e48d38.png">
   <img width="656" alt="image" src="https://user-images.githubusercontent.com/42576980/208376167-a22da87d-dfe1-4bd9-9110-6d85298a722c.png">
   I tested your code but didn't get the expected results. Please confirm
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1328010860

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13005)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=BUG) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=BUG) [62 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=VULNERABILITY) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=VULNERABILITY) [10 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=SECURITY_HOTSPOT) [12 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=CODE_SMELL) [1035 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=CODE_SMELL)
   
   [![17.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '17.4%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_coverage&view=list) [17.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_coverage&view=list)  
   [![5.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10-16px.png '5.4%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_duplicated_lines_density&view=list) [5.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] JinyLeeChina commented on a diff in pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on code in PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#discussion_r1051913368


##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -684,6 +685,9 @@ private void initTaskQueue() {
         if (processInstance.isComplementData() && complementListDate.size() == 0) {
             Map<String, String> cmdParam = JSONUtils.toMap(processInstance.getCommandParam());
             if (cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {

Review Comment:
   This is not just a complement. There should be a similar problem when you directly click Start



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] Radeity commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
Radeity commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1358733806

    > I tested your code but didn't get the expected results. Please confirm
   
   I'll check later today.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] Radeity commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
Radeity commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1359989005

   > <img alt="image" width="745" src="https://user-images.githubusercontent.com/42576980/208375851-b4ec447a-48d0-4eac-a6a9-cfcd81e48d38.png">
   > 
   > <img alt="image" width="656" src="https://user-images.githubusercontent.com/42576980/208376167-a22da87d-dfe1-4bd9-9110-6d85298a722c.png">
   
   Hi, @JinyLeeChina, i've checked and find nothing wrong, i wonder what's wrong in the picture? It seems like startup parameters update global parameters.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1363839787

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13005)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=BUG) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=BUG) [62 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=VULNERABILITY) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=VULNERABILITY) [10 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=SECURITY_HOTSPOT) [12 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=CODE_SMELL) [1032 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=CODE_SMELL)
   
   [![17.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '17.2%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_coverage&view=list) [17.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_coverage&view=list)  
   [![5.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10-16px.png '5.4%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_duplicated_lines_density&view=list) [5.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
Radeity commented on code in PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#discussion_r1055092343


##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -684,6 +685,9 @@ private void initTaskQueue() {
         if (processInstance.isComplementData() && complementListDate.size() == 0) {
             Map<String, String> cmdParam = JSONUtils.toMap(processInstance.getCommandParam());
             if (cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {

Review Comment:
   > This is not just a complement. There should be a similar problem when you directly click Start
   
   This part fixes that cmd param can overwrite global param when executing complement, change in ProcessService fix bug when directly click Start.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1328009434

   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/13005?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`2.0.8-prepare@de76f81`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   ```diff
   @@               Coverage Diff                @@
   ##             2.0.8-prepare   #13005   +/-   ##
   ================================================
     Coverage                 ?   20.69%           
     Complexity               ?     1599           
   ================================================
     Files                    ?      540           
     Lines                    ?    23021           
     Branches                 ?     2752           
   ================================================
     Hits                     ?     4765           
     Misses                   ?    17764           
     Partials                 ?      492           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] JinyLeeChina commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1328423366

   OK, I will test it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] Radeity commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
Radeity commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1361026678

   > Yes, I find `startup parameters` can update global parameters, but can't update local parameters, please check
   
   According to the [doc](https://dolphinscheduler.apache.org/#/zh-cn/docs/3.1.2/guide/parameter/priority), local parameter have higher priority than global and startup parameters.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1364467281

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13005)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=BUG) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=BUG) [62 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=VULNERABILITY) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=VULNERABILITY) [10 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=SECURITY_HOTSPOT) [12 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=CODE_SMELL) [1035 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13005&resolved=false&types=CODE_SMELL)
   
   [![17.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '17.2%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_coverage&view=list) [17.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_coverage&view=list)  
   [![5.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10-16px.png '5.4%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_duplicated_lines_density&view=list) [5.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13005&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] JinyLeeChina commented on a diff in pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on code in PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#discussion_r1056056044


##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -684,6 +685,9 @@ private void initTaskQueue() {
         if (processInstance.isComplementData() && complementListDate.size() == 0) {
             Map<String, String> cmdParam = JSONUtils.toMap(processInstance.getCommandParam());
             if (cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {

Review Comment:
   I mean, it's not just a matter of complement. Can you help fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] JinyLeeChina commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1361020291

   > > <img alt="image" width="745" src="https://user-images.githubusercontent.com/42576980/208375851-b4ec447a-48d0-4eac-a6a9-cfcd81e48d38.png">
   > > <img alt="image" width="656" src="https://user-images.githubusercontent.com/42576980/208376167-a22da87d-dfe1-4bd9-9110-6d85298a722c.png">
   > 
   > Hi, @JinyLeeChina, i've checked and find nothing wrong, i wonder what's wrong in the picture? It seems like startup parameters update global parameters.
   
   Yes, I find `startup parameters` can update global parameters, but can't update local parameters, please check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] Radeity commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
Radeity commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1361029152

   > Yes, I find `startup parameters` can update global parameters, but can't update local parameters, please check
   
   According to the [doc](https://dolphinscheduler.apache.org/#/zh-cn/docs/3.1.2/guide/parameter/priority), local parameter has higher priority than global and startup parameter, if you don't set local parameter with same name, then you can use different startup parameter in the task.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] Radeity commented on pull request #13005: [Bug-12960][Master] Fix that start parameters cannot update global variables

Posted by GitBox <gi...@apache.org>.
Radeity commented on PR #13005:
URL: https://github.com/apache/dolphinscheduler/pull/13005#issuecomment-1328008873

   @JinyLeeChina PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org