[GitHub] [accumulo] keith-turner commented on a change in pull request #1199: Fix #1122 Added concurrent structures to ThriftTransportPool

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1199: Fix #1122 Added concurrent structures to ThriftTransportPool
URL: https://github.com/apache/accumulo/pull/1199#discussion_r293131609
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java
 ##########
 @@ -67,9 +68,9 @@ public CachedConnection reserveAny() {
     }
   }
 
-  private Map<ThriftTransportKey,CachedConnections> cache = new HashMap<>();
-  private Map<ThriftTransportKey,Long> errorCount = new HashMap<>();
-  private Map<ThriftTransportKey,Long> errorTime = new HashMap<>();
+  private Map<ThriftTransportKey,CachedConnections> cache = new ConcurrentHashMap<>();
+  private Map<ThriftTransportKey,Long> errorCount = new ConcurrentHashMap<>();
+  private Map<ThriftTransportKey,Long> errorTime = new ConcurrentHashMap<>();
   private Set<ThriftTransportKey> serversWarnedAbout = new HashSet<>();
 
 Review comment:
   this should be a concurrent set

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services