You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/27 07:06:54 UTC
[GitHub] [incubator-doris] marising opened a new pull request #4190: [Feature]Add fetch/update/clear proto of fe&be for cache
marising opened a new pull request #4190:
URL: https://github.com/apache/incubator-doris/pull/4190
## Proposed changes
#2581
1. Define the interface of fetch_cache，update_cache，clear_cache
2. Define the data structure of request and response
3. Frontend call be through BackendServiceProxy
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Doris's issues](https://github.com/apache/incubator-doris/issues), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related issues ID, like "#4071 Add pull request template to doris project"
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #4190: [Feature]Add fetch/update/clear proto of fe&be for cache
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #4190:
URL: https://github.com/apache/incubator-doris/pull/4190#discussion_r462713558
##########
File path: gensrc/proto/internal_service.proto
##########
@@ -147,6 +147,59 @@ message PFetchDataResult {
optional PQueryStatistics query_statistics = 4;
};
+//Add message definition to fetch and update cache
+enum PCacheStatus {
+ DEFAULT = 0;
+ CACHE_OK = 1;
+ PARAM_ERROR = 2;
+ SIZE_OVER_LIMIT = 3;
+ NO_SQL_KEY = 4;
+ NO_PARTITION_KEY = 5;
+ INVALID_KEY_RANGE = 6;
+ DATA_OVERDUE = 7;
+ EMPTY_DATA = 8;
+};
+
+message PCacheParam {
+ required int64 partition_key = 1;
Review comment:
For protobuf, we prefer optional than required.
##########
File path: gensrc/proto/internal_service.proto
##########
@@ -147,6 +147,59 @@ message PFetchDataResult {
optional PQueryStatistics query_statistics = 4;
};
+//Add message definition to fetch and update cache
+enum PCacheStatus {
+ DEFAULT = 0;
+ CACHE_OK = 1;
+ PARAM_ERROR = 2;
+ SIZE_OVER_LIMIT = 3;
+ NO_SQL_KEY = 4;
+ NO_PARTITION_KEY = 5;
+ INVALID_KEY_RANGE = 6;
+ DATA_OVERDUE = 7;
+ EMPTY_DATA = 8;
+};
+
+message PCacheParam {
+ required int64 partition_key = 1;
+ required int64 last_version = 2;
+ required int64 last_version_time = 3;
+};
+
+message PCacheValue {
+ required PCacheParam param = 1;
+ required int32 data_size = 2;
+ repeated bytes row = 3;
+};
+
+//for update&clear return
+message PCacheResponse {
+ required PCacheStatus status = 1;
+};
+
+message PUpdateCacheRequest{
+ required PUniqueId sql_key = 1;
+ repeated PCacheValue value = 2;
+};
+
+message PFetchCacheRequest {
+ required PUniqueId sql_key = 1;
+ repeated PCacheParam param = 2;
+};
+
+message PFetchCacheResult {
+ required PCacheStatus status = 1;
+ repeated PCacheValue value = 2;
+};
+
+message PClearCacheRequest {
+ //0 clear all, 1 invoke prune, 2 clear before_time, 3 clear sql_key
+ required int32 clear_type = 1;
Review comment:
Would better define the clear_type to enum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #4190: [Feature]Add fetch/update/clear proto of fe&be for cache
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #4190:
URL: https://github.com/apache/incubator-doris/pull/4190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org