You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2010/04/07 19:18:34 UTC
[jira] Created: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Add directory renaming test to FileContextMainOperationsBaseTest
----------------------------------------------------------------
Key: HADOOP-6689
URL: https://issues.apache.org/jira/browse/HADOOP-6689
Project: Hadoop Common
Issue Type: Test
Components: fs, test
Reporter: Eli Collins
Assignee: Eli Collins
Priority: Minor
I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-6689:
------------------------------------
Hadoop Flags: [Reviewed]
Fix Version/s: 0.22.0
Affects Version/s: 0.22.0
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6689-1.patch, hadoop-6689-2.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6689:
--------------------------------
Status: Open (was: Patch Available)
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hadoop-6689-1.patch, hadoop-6689-2.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6689:
--------------------------------
Status: Patch Available (was: Open)
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hadoop-6689-1.patch, hadoop-6689-2.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856492#action_12856492 ]
Suresh Srinivas commented on HADOOP-6689:
-----------------------------------------
+1 for the patch.
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hadoop-6689-1.patch, hadoop-6689-2.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854618#action_12854618 ]
Hadoop QA commented on HADOOP-6689:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12441059/hadoop-6689-1.patch
against trunk revision 931226.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/445/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/445/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/445/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/445/console
This message is automatically generated.
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hadoop-6689-1.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6689:
--------------------------------
Attachment: hadoop-6689-2.patch
Right patch this time.
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hadoop-6689-1.patch, hadoop-6689-2.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6689:
--------------------------------
Attachment: hadoop-6689-1.patch
Adds testRenameDirectoryAsEmptyDirectory and fixes some comments in testRenameDirectoryAsNonEmptyDirectory. Tested on HDFS and locally via TestHDFSFileContextMainOperations and TestHDFSFileContextMainOperations.
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hadoop-6689-1.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856503#action_12856503 ]
Hudson commented on HADOOP-6689:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #217 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/217/])
HADOOP-6689. Add directory renaming test to existing FileContext tests. Contributed by Eli Collins.
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6689-1.patch, hadoop-6689-2.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-6689:
------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
I committed the patch. Thank you Eli.
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-6689-1.patch, hadoop-6689-2.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854638#action_12854638 ]
Hadoop QA commented on HADOOP-6689:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12441066/hadoop-6689-2.patch
against trunk revision 931226.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/446/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/446/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/446/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/446/console
This message is automatically generated.
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hadoop-6689-1.patch, hadoop-6689-2.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6689) Add directory renaming test to
FileContextMainOperationsBaseTest
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6689:
--------------------------------
Status: Patch Available (was: Open)
> Add directory renaming test to FileContextMainOperationsBaseTest
> ----------------------------------------------------------------
>
> Key: HADOOP-6689
> URL: https://issues.apache.org/jira/browse/HADOOP-6689
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hadoop-6689-1.patch
>
>
> I noticed FileContextMainOperationsBaseTest does not have a test that renames an empty directory to an empty directory (and shows that this fails without the overwrite option).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.