You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/09/01 22:04:48 UTC
Review Request 51585: let getId() return unique name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51585/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11
Repository: geode
Description
-------
Should return the internal unique name of the index for each lucene index.
Diffs
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfile.java 720d20d
Diff: https://reviews.apache.org/r/51585/diff/
Testing
-------
geode-lucene:precheckin
Thanks,
xiaojian zhou
Re: Review Request 51585: let getId() return unique name
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51585/
-----------------------------------------------------------
(Updated Sept. 2, 2016, 12:48 a.m.)
Review request for geode and Dan Smith.
Changes
-------
a revised version using "lucene_" as prefix
Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11
Repository: geode
Description
-------
Should return the internal unique name of the index for each lucene index.
Diffs (updated)
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfile.java 720d20d
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java 29a8e62
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfileJUnitTest.java c64dd3d
Diff: https://reviews.apache.org/r/51585/diff/
Testing
-------
geode-lucene:precheckin
Thanks,
xiaojian zhou
Re: Review Request 51585: let getId() return unique name
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51585/
-----------------------------------------------------------
(Updated Sept. 1, 2016, 10:55 p.m.)
Review request for geode and Dan Smith.
Changes
-------
refactor it. It should contain region name all the time.
Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11
Repository: geode
Description
-------
Should return the internal unique name of the index for each lucene index.
Diffs (updated)
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfile.java 720d20d
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java 29a8e62
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfileJUnitTest.java c64dd3d
Diff: https://reviews.apache.org/r/51585/diff/
Testing
-------
geode-lucene:precheckin
Thanks,
xiaojian zhou
Re: Review Request 51585: let getId() return unique name
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51585/#review147613
-----------------------------------------------------------
I think the ID needs to include something indicating that this profile is for lucene, rather than some other cache service. Maybe the fully qualified name of the class? I don't think adding the region really makes a difference, because the profile is already region specific.
- Dan Smith
On Sept. 1, 2016, 10:04 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51585/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2016, 10:04 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-11
> https://issues.apache.org/jira/browse/GEODE-11
>
>
> Repository: geode
>
>
> Description
> -------
>
> Should return the internal unique name of the index for each lucene index.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfile.java 720d20d
>
> Diff: https://reviews.apache.org/r/51585/diff/
>
>
> Testing
> -------
>
> geode-lucene:precheckin
>
>
> Thanks,
>
> xiaojian zhou
>
>