You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/04/11 10:24:00 UTC
[jira] [Commented] (KYLIN-4780) Refactor AbstractExecutable to
extract the notification relevant business logic into a single component
[ https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318718#comment-17318718 ]
ASF GitHub Bot commented on KYLIN-4780:
---------------------------------------
codecov-io edited a comment on pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#issuecomment-799678944
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=h1) Report
> Merging [#1596](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=desc) (6969865) into [master](https://codecov.io/gh/apache/kylin/commit/02500818d85955b1125340eaa19ab88a634a5181?el=desc) (0250081) will **decrease** coverage by `0.09%`.
> The diff coverage is `9.82%`.
[](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1596 +/- ##
============================================
- Coverage 25.42% 25.32% -0.10%
- Complexity 6765 6774 +9
============================================
Files 1508 1516 +8
Lines 93918 94436 +518
Branches 13158 13233 +75
============================================
+ Hits 23877 23916 +39
- Misses 67662 68136 +474
- Partials 2379 2384 +5
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.42% <0.00%> (-0.05%)` | `51.00 <0.00> (ø)` | |
| [...rg/apache/kylin/common/notify/DingTalkService.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvRGluZ1RhbGtTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...va/org/apache/kylin/common/notify/MailService.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTWFpbFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/kylin/common/notify/NotificationContext.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZpY2F0aW9uQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/kylin/common/notify/NotificationTransmitter.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZpY2F0aW9uVHJhbnNtaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/kylin/common/notify/NotifyServiceBase.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZ5U2VydmljZUJhc2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ylin/common/notify/util/NotificationConstants.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvdXRpbC9Ob3RpZmljYXRpb25Db25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `32.41% <0.00%> (-1.16%)` | `12.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `35.83% <0.00%> (-0.81%)` | `44.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/kylin/cube/CubeSegment.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVTZWdtZW50LmphdmE=) | `41.97% <0.00%> (-0.31%)` | `65.00 <0.00> (ø)` | |
| ... and [94 more](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=footer). Last update [ca08012...6969865](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Refactor AbstractExecutable to extract the notification relevant business logic into a single component
> -------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4780
> URL: https://issues.apache.org/jira/browse/KYLIN-4780
> Project: Kylin
> Issue Type: Improvement
> Components: Integration
> Reporter: vinoyang
> Assignee: chenjie
> Priority: Major
>
> Currently, Kylin supports mail service to know the change around the cube. However, there are some issues about the design, e.g.
> * AbstractExecutable contains an implementation of the mechanism of a notification listener, but only support mail service, it does not belong there;
> * The current implementation is hard to scale to other notification e.g. Ding Talk(which is a popular production supports by Alibaba)
> I propose to refactor the current implementation to extract the notification logic and redesign a new common notification/listener
--
This message was sent by Atlassian Jira
(v8.3.4#803005)