[GitHub] [arrow-adbc] kou commented on a diff in pull request #1048: feat(go): add basic driver logging

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #1048:
URL: https://github.com/apache/arrow-adbc/pull/1048#discussion_r1322225599


##########
ci/linux-packages/debian/rules:
##########
@@ -31,17 +31,19 @@ export DEB_BUILD_MAINT_OPTIONS=reproducible=-timeless
 CMAKE_BUILD_TYPE = RelWithDebInfo
 
 override_dh_auto_configure:
-	dh_auto_configure				\
-	  --sourcedirectory=c/		                \
-	  --builddirectory=c.build               	\
-	  --buildsystem=cmake+ninja			\
-	  --						\
-	  -DCMAKE_BUILD_TYPE=$(CMAKE_BUILD_TYPE)        \
-          -DADBC_DRIVER_MANAGER=ON                      \
-          -DADBC_DRIVER_POSTGRESQL=ON                   \
-          -DADBC_DRIVER_SQLITE=ON                       \
-          -DADBC_DRIVER_FLIGHTSQL=ON                    \
-          -DADBC_DRIVER_SNOWFLAKE=ON
+	env \
+	  PATH=$(PATH):/usr/lib/go-1.20/bin \

Review Comment:
   I think that environment variable not Makefile variable is better here:
   
   ```suggestion
   	  PATH=$${PATH}:/usr/lib/go-1.20/bin			\
   ```
   
   (`PATH=/usr/lib/go-1.20/bin:$${PATH}` may be better to ensure using Go 1.20 if available.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org