You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Parth Chandra <pc...@maprtech.com> on 2014/10/13 19:36:16 UTC
Review Request 26653: DRILL-1505: Enabling Frgment memory limit
causes out of memory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26653/
-----------------------------------------------------------
Review request for drill, Hanifi Gunes and Steven Phillips.
Repository: drill-git
Description
-------
Bitservers would allocte many FragmentManagers, use only one and not explicitly close the ones that were not used.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java bd64640
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java 5c126e1
exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java de54f6a
Diff: https://reviews.apache.org/r/26653/diff/
Testing
-------
Reproduced case with TPCH-07; system would run out of memory after two or three runs. After the fix, ran the tpch-07 query 15 times without running out.
Thanks,
Parth Chandra
Re: Review Request 26653: DRILL-1504: Enabling Frgment memory limit
causes out of memory
Posted by Hanifi Gunes <hg...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26653/#review56868
-----------------------------------------------------------
Ship it!
Ship It!
- Hanifi Gunes
On Oct. 13, 2014, 5:39 p.m., Parth Chandra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26653/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 5:39 p.m.)
>
>
> Review request for drill, Hanifi Gunes and Steven Phillips.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Bitservers would allocte many FragmentManagers, use only one and not explicitly close the ones that were not used.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java bd64640
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java 5c126e1
> exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java de54f6a
>
> Diff: https://reviews.apache.org/r/26653/diff/
>
>
> Testing
> -------
>
> Reproduced case with TPCH-07; system would run out of memory after two or three runs. After the fix, ran the tpch-07 query 15 times without running out.
>
>
> Thanks,
>
> Parth Chandra
>
>
Re: Review Request 26653: DRILL-1504: Enabling Frgment memory limit
causes out of memory
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26653/
-----------------------------------------------------------
(Updated Oct. 13, 2014, 5:39 p.m.)
Review request for drill, Hanifi Gunes and Steven Phillips.
Summary (updated)
-----------------
DRILL-1504: Enabling Frgment memory limit causes out of memory
Repository: drill-git
Description
-------
Bitservers would allocte many FragmentManagers, use only one and not explicitly close the ones that were not used.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/memory/Accountor.java bd64640
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java 5c126e1
exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java de54f6a
Diff: https://reviews.apache.org/r/26653/diff/
Testing
-------
Reproduced case with TPCH-07; system would run out of memory after two or three runs. After the fix, ran the tpch-07 query 15 times without running out.
Thanks,
Parth Chandra