You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Sam Berlin (JIRA)" <ji...@apache.org> on 2008/05/29 20:37:45 UTC
[jira] Created: (HTTPCLIENT-779) toplevel exception cleanup
toplevel exception cleanup
--------------------------
Key: HTTPCLIENT-779
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-779
Project: HttpComponents HttpClient
Issue Type: Improvement
Affects Versions: 4.0 Alpha 4
Reporter: Sam Berlin
Fix For: 4.0 Beta 1
HttpClient.execute should throw only one exception, for easier general use.
HttpMethod constructors (HttpGet, HttpPut, etc..) should throw IllegalArgumentException in the string constructor (imply the string is pre-checked). People wanting to see a URIException can use 'new HttpGet(new URI(uri))' and trigger the exception from the explicit URI creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-779) toplevel exception cleanup
Posted by "Sam Berlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sam Berlin updated HTTPCLIENT-779:
----------------------------------
Attachment: httpclient-exception-cleanup.txt
take two.
> toplevel exception cleanup
> --------------------------
>
> Key: HTTPCLIENT-779
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-779
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Affects Versions: 4.0 Alpha 4
> Reporter: Sam Berlin
> Fix For: 4.0 Beta 1
>
> Attachments: httpclient-exception-cleanup.txt, httpclient-exception-cleanup.txt
>
>
> HttpClient.execute should throw only one exception, for easier general use.
> HttpMethod constructors (HttpGet, HttpPut, etc..) should throw IllegalArgumentException in the string constructor (imply the string is pre-checked). People wanting to see a URIException can use 'new HttpGet(new URI(uri))' and trigger the exception from the explicit URI creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-779) toplevel exception cleanup
Posted by "Sam Berlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600903#action_12600903 ]
Sam Berlin commented on HTTPCLIENT-779:
---------------------------------------
Sure thing, that's a good idea.
> toplevel exception cleanup
> --------------------------
>
> Key: HTTPCLIENT-779
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-779
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Affects Versions: 4.0 Alpha 4
> Reporter: Sam Berlin
> Fix For: 4.0 Beta 1
>
> Attachments: httpclient-exception-cleanup.txt
>
>
> HttpClient.execute should throw only one exception, for easier general use.
> HttpMethod constructors (HttpGet, HttpPut, etc..) should throw IllegalArgumentException in the string constructor (imply the string is pre-checked). People wanting to see a URIException can use 'new HttpGet(new URI(uri))' and trigger the exception from the explicit URI creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-779) toplevel exception cleanup
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603357#action_12603357 ]
Oleg Kalnichevski commented on HTTPCLIENT-779:
----------------------------------------------
Sam, go ahead and commit the patch.
Oleg
> toplevel exception cleanup
> --------------------------
>
> Key: HTTPCLIENT-779
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-779
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Affects Versions: 4.0 Alpha 4
> Reporter: Sam Berlin
> Fix For: 4.0 Beta 1
>
> Attachments: httpclient-exception-cleanup.txt, httpclient-exception-cleanup.txt
>
>
> HttpClient.execute should throw only one exception, for easier general use.
> HttpMethod constructors (HttpGet, HttpPut, etc..) should throw IllegalArgumentException in the string constructor (imply the string is pre-checked). People wanting to see a URIException can use 'new HttpGet(new URI(uri))' and trigger the exception from the explicit URI creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-779) toplevel exception cleanup
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600901#action_12600901 ]
Oleg Kalnichevski commented on HTTPCLIENT-779:
----------------------------------------------
Sam,
I think it is a pretty bad idea to re-throw protocol exceptions as a plain vanilla IOException. Could you please create a special subclass of IOException, ClientProtocolException or some such, for that end? I still would like to have an option to catch protocol exceptions thrown by the HttpClient#execute method.
Oleg
> toplevel exception cleanup
> --------------------------
>
> Key: HTTPCLIENT-779
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-779
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Affects Versions: 4.0 Alpha 4
> Reporter: Sam Berlin
> Fix For: 4.0 Beta 1
>
> Attachments: httpclient-exception-cleanup.txt
>
>
> HttpClient.execute should throw only one exception, for easier general use.
> HttpMethod constructors (HttpGet, HttpPut, etc..) should throw IllegalArgumentException in the string constructor (imply the string is pre-checked). People wanting to see a URIException can use 'new HttpGet(new URI(uri))' and trigger the exception from the explicit URI creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-779) toplevel exception cleanup
Posted by "Sam Berlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sam Berlin updated HTTPCLIENT-779:
----------------------------------
Attachment: httpclient-exception-cleanup.txt
patch attached.
> toplevel exception cleanup
> --------------------------
>
> Key: HTTPCLIENT-779
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-779
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Affects Versions: 4.0 Alpha 4
> Reporter: Sam Berlin
> Fix For: 4.0 Beta 1
>
> Attachments: httpclient-exception-cleanup.txt
>
>
> HttpClient.execute should throw only one exception, for easier general use.
> HttpMethod constructors (HttpGet, HttpPut, etc..) should throw IllegalArgumentException in the string constructor (imply the string is pre-checked). People wanting to see a URIException can use 'new HttpGet(new URI(uri))' and trigger the exception from the explicit URI creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Closed: (HTTPCLIENT-779) toplevel exception cleanup
Posted by "Sam Berlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sam Berlin closed HTTPCLIENT-779.
---------------------------------
Resolution: Fixed
Committed.
> toplevel exception cleanup
> --------------------------
>
> Key: HTTPCLIENT-779
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-779
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Affects Versions: 4.0 Alpha 4
> Reporter: Sam Berlin
> Fix For: 4.0 Beta 1
>
> Attachments: httpclient-exception-cleanup.txt, httpclient-exception-cleanup.txt
>
>
> HttpClient.execute should throw only one exception, for easier general use.
> HttpMethod constructors (HttpGet, HttpPut, etc..) should throw IllegalArgumentException in the string constructor (imply the string is pre-checked). People wanting to see a URIException can use 'new HttpGet(new URI(uri))' and trigger the exception from the explicit URI creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org