You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/26 10:55:38 UTC
[GitHub] [flink] XComp opened a new pull request #15034: Flink 21030 1.12
XComp opened a new pull request #15034:
URL: https://github.com/apache/flink/pull/15034
## What is the purpose of the change
Applies FLINK-21030 related changes of PR #14847 to the `release-1.12` branch.
## Brief change log
I only skipped cherry-picking [6fd59e3](https://github.com/apache/flink/pull/14847/commits/6fd59e36dc41741ee4d40211d6ca87c9d5c05b5a) as it is based on some refactoring in `master` post-1.12
## Verifying this change
Rerun changed tests locally
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15034: [FLINK-21030][runtime] Backport of FLINK-21030 to release-1.12
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15034:
URL: https://github.com/apache/flink/pull/15034#issuecomment-786585064
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "329e80e7b7f974209271156a31faee151154813f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "329e80e7b7f974209271156a31faee151154813f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 329e80e7b7f974209271156a31faee151154813f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15034: [FLINK-21030][runtime] Backport of FLINK-21030 to release-1.12
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15034:
URL: https://github.com/apache/flink/pull/15034#issuecomment-786574073
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 329e80e7b7f974209271156a31faee151154813f (Fri Feb 26 10:57:09 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #15034: [FLINK-21030][runtime] Backport of FLINK-21030 to release-1.12
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #15034:
URL: https://github.com/apache/flink/pull/15034#issuecomment-786647081
The failed test seems to be unrelated: https://issues.apache.org/jira/browse/FLINK-21518. Merging this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15034: [FLINK-21030][runtime] Backport of FLINK-21030 to release-1.12
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15034:
URL: https://github.com/apache/flink/pull/15034#issuecomment-786585064
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "329e80e7b7f974209271156a31faee151154813f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13845",
"triggerID" : "329e80e7b7f974209271156a31faee151154813f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 329e80e7b7f974209271156a31faee151154813f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13845)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #15034: [FLINK-21030][runtime] Backport of FLINK-21030 to release-1.12
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #15034:
URL: https://github.com/apache/flink/pull/15034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #15034: [FLINK-21030][runtime] Backport of FLINK-21030 to release-1.12
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #15034:
URL: https://github.com/apache/flink/pull/15034#issuecomment-786654460
Manually merged via e9af362f0caa16e75e66aa1403c62666e77f98f0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org