You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/16 18:04:46 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1411: libxx: Integrate uClibc++ latest official release

xiaoxiang781216 opened a new pull request #1411:
URL: https://github.com/apache/incubator-nuttx/pull/1411


   ## Summary
   With the recent enhancement, we can directly use the offiical uClibc++ package, so let's download the package from the official website.
   
   ## Impact
   User don't need manually setup uClibc++ environment, the build system will do it automatically.
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1411: libxx: Integrate uClibc++ latest official release

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1411:
URL: https://github.com/apache/incubator-nuttx/pull/1411#discussion_r456389822



##########
File path: libs/libxx/Makefile
##########
@@ -95,7 +97,7 @@ clean:
 	$(call DELFILE, $(BIN))
 	$(call CLEAN)
 
-distclean: clean
+distclean:: clean

Review comment:
       @xiaoxiang781216 users of other C++ libraries will need to be aware if this change, right?  Their `distclean` would fail otherwise.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1411: libxx: Integrate uClibc++ latest official release

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1411:
URL: https://github.com/apache/incubator-nuttx/pull/1411#discussion_r456187874



##########
File path: tools/Makefile.unix
##########
@@ -313,6 +313,7 @@ ifneq ($(CONFIG_ARCH_CHIP),)
 endif
 
 dirlinks: include/arch include/arch/board include/arch/chip $(ARCH_SRC)/board $(ARCH_SRC)/chip drivers/platform
+	$(Q) $(MAKE) -C libs/libxx dirlinks TOPDIR="$(TOPDIR)"

Review comment:
       @Ouss4 done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1411: libxx: Integrate uClibc++ latest official release

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1411:
URL: https://github.com/apache/incubator-nuttx/pull/1411#discussion_r456389822



##########
File path: libs/libxx/Makefile
##########
@@ -95,7 +97,7 @@ clean:
 	$(call DELFILE, $(BIN))
 	$(call CLEAN)
 
-distclean: clean
+distclean:: clean

Review comment:
       @xiaoxiang781216 users of other C++ libraries will need to be aware if this change, right?  They `distclean` would fail otherwise.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1411: libxx: Integrate uClibc++ latest official release

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1411:
URL: https://github.com/apache/incubator-nuttx/pull/1411#discussion_r456071951



##########
File path: tools/Makefile.unix
##########
@@ -313,6 +313,7 @@ ifneq ($(CONFIG_ARCH_CHIP),)
 endif
 
 dirlinks: include/arch include/arch/board include/arch/chip $(ARCH_SRC)/board $(ARCH_SRC)/chip drivers/platform
+	$(Q) $(MAKE) -C libs/libxx dirlinks TOPDIR="$(TOPDIR)"

Review comment:
       This should go to Makefile.win too.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1411: libxx: Integrate uClibc++ latest official release

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1411:
URL: https://github.com/apache/incubator-nuttx/pull/1411#discussion_r456501102



##########
File path: libs/libxx/Makefile
##########
@@ -95,7 +97,7 @@ clean:
 	$(call DELFILE, $(BIN))
 	$(call CLEAN)
 
-distclean: clean
+distclean:: clean

Review comment:
       I will provide the new patch for libcxx too. Like uClibc++, we don't need maintain the private copy anymore, the official release can be directly used.
   BTW, I can't fix libcxx/Make.defs since it is in Alan's git:
   https://bitbucket.org/acassis/libcxx/src/master/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1411: libxx: Integrate uClibc++ latest official release

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1411:
URL: https://github.com/apache/incubator-nuttx/pull/1411#discussion_r456501102



##########
File path: libs/libxx/Makefile
##########
@@ -95,7 +97,7 @@ clean:
 	$(call DELFILE, $(BIN))
 	$(call CLEAN)
 
-distclean: clean
+distclean:: clean

Review comment:
       I will provide the new patch for libcxx too. Like uClibc++, we don't need maintain the private copy anymore, the official release can be directly used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1411: libxx: Integrate uClibc++ latest official release

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1411:
URL: https://github.com/apache/incubator-nuttx/pull/1411#discussion_r456180589



##########
File path: tools/Makefile.unix
##########
@@ -313,6 +313,7 @@ ifneq ($(CONFIG_ARCH_CHIP),)
 endif
 
 dirlinks: include/arch include/arch/board include/arch/chip $(ARCH_SRC)/board $(ARCH_SRC)/chip drivers/platform
+	$(Q) $(MAKE) -C libs/libxx dirlinks TOPDIR="$(TOPDIR)"

Review comment:
       Good catch, I will provide a patch fix it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 merged pull request #1411: libxx: Integrate uClibc++ latest official release

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1411:
URL: https://github.com/apache/incubator-nuttx/pull/1411


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org