[GitHub] [solr] risdenk commented on a diff in pull request #953: SOLR-16311: Simplify assert statement

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #953:
URL: https://github.com/apache/solr/pull/953#discussion_r997711826


##########
solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java:
##########
@@ -287,13 +286,13 @@ public void testBasicSelect() throws Exception {
     tuple = tuples.get(7);
     assertEquals(tuple.getLong("id").longValue(), 1);
     assertEquals(tuple.getLong("field_i").longValue(), 7);
-    assert (tuple.get("str_s").equals("a"));
+    assertEquals("a", tuple.get("str_s"));
     assertEquals(tuple.getLong("field_i").longValue(), 7);
     assertEquals(tuple.getDouble("field_f"), 7.5, 0.0);
     assertEquals(tuple.getDouble("field_d"), 7.5, 0.0);
     assertEquals(tuple.getLong("field_l").longValue(), 7);
 
-    // Assert field order
+    // assertTruefield order

Review Comment:
   Fix this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org