[GitHub] matthiasblaesing commented on issue #878: fix for NETBEANS-1252

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #878: fix for NETBEANS-1252
URL: https://github.com/apache/incubator-netbeans/pull/878#issuecomment-421541341
 
 
   The change itself looks sane. The removed implementation looks like a direct copy from the JDK implementation, so switching to the JDKs default implementation is sane.
   
   I'd like you do adjust the commit though:
   - the summary (first) line of the commit should hold the referenced issue in brackets as first element
   - as the name suggests the first line should give a summary of the change (why was it done)
   - then an empty line should follow
   - the rest of the message should give a reasoning for the change
   
   In this case:
   
   ```
   [NETBEANS-1252] Fix shifted cursor in output window with GDK_SCALE=2
   
   Remove custom implementation of #viewToModel and# modelToView methods, ....
   ```
   
   You can update the message by amending the commit and doing a force push of the branch the PR is based on.
   
   A final comment: You introduced changes not directly related to the fix (whitespace removal + constant introduction). They are sane, but in general that should not be done. (in this case keep it, as I already looked through it).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists