You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GJL <gi...@git.apache.org> on 2018/05/01 04:27:01 UTC

[GitHub] flink pull request #5944: [FLINK-8900] [yarn] Set correct application status...

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5944#discussion_r185163871
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnJobClusterEntrypoint.java ---
    @@ -131,6 +133,17 @@ protected JobGraph retrieveJobGraph(Configuration configuration) throws FlinkExc
     		}
     	}
     
    +	@Override
    +	protected void registerShutdownActions(CompletableFuture<ApplicationStatus> terminationFuture) {
    +		terminationFuture.whenComplete((status, throwable) ->
    --- End diff --
    
    `throwable` isn't used. If `terminationFuture` cannot be completed exceptionally, `thenAccept` should be used. 


---