You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/26 14:43:36 UTC

[PR] Fix GraalVM reflection metadata for SQL federation provider type [shardingsphere]

terrymanu opened a new pull request, #39973:
URL: https://github.com/apache/shardingsphere/pull/39973

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix GraalVM reflection metadata for SQL federation provider type [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39973:
URL: https://github.com/apache/shardingsphere/pull/39973


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix GraalVM reflection metadata for SQL federation provider type [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39973:
URL: https://github.com/apache/shardingsphere/pull/39973#issuecomment-5847171633

   ### Result
   
   **Review Result: Mergeable**
   
   I added native-image reflection registration for `getProviderType()` in the local SQL Federation YAML metadata. This assessment covers only the local fix; it does not mean PR #39972 as a whole is ready to merge.
   
   ### Evidence
   
   - The failing log identifies this getter in a `MissingReflectionRegistrationError`. The new registration uses the same reachability condition as the class’s other registered getters.
   - JSON validation, resource packaging, and a comparison of the source and packaged resource passed. The new method is the only metadata change.
   - Spotless and Checkstyle passed for the affected modules.
   
   ### Coverage
   
   - Changed file: `infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reachability-metadata.json`.
   - I could not rerun the GraalVM native tests because `native-image` is unavailable locally. CI must verify that the job passes with this patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org