[GitHub] mli commented on issue #8152: memory save

[gi...@git.apache.org]

mli commented on issue #8152: memory save
URL: https://github.com/apache/incubator-mxnet/pull/8152#issuecomment-334579301
 
 
   Agree that using tuple and iterator can reduce the memory. But Eric's point is valid, this PR puts too many things in a single expression (i.e. `cargs = ...`), which makes the codes harder to read. 
   
   maybe we can write a generator for cargs, which can further reduce memory, and break single line into multiple lines to improve readability. 
   
   also, is there any benchmark showing that this kinds of modification can improve things in a notiable way?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services