[GitHub] incubator-rya pull request #122: [WIP] adding metadata to individual stateme...

[pujav65 <gi...@git.apache.org>]

GitHub user pujav65 opened a pull request:

    https://github.com/apache/incubator-rya/pull/122

    [WIP] adding metadata to individual statements

    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    
      http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
    ## Description
    >What Changed?
    [Brief Description of what changed]
    
    ### Tests
    >Coverage?
    
    [Description of what tests were written]
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-NUMBER)
    
    ### Checklist
    - [ ] Code Review
    - [ ] Squash Commits
    
    #### People To Reivew
    [Add those who should review this]
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pujav65/incubator-rya f/addedContext

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #122
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #122: [WIP] adding metadata to individual stateme...

[amihalik <gi...@git.apache.org>]

Github user amihalik commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/122#discussion_r88981217
  
    --- Diff: common/rya.api/src/main/java/org/apache/rya/api/domain/StatementMetadata.java ---
    @@ -0,0 +1,73 @@
    +package org.apache.rya.api.domain;
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * 
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +import java.io.UnsupportedEncodingException;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import org.apache.rya.api.persist.RdfDAOException;
    +
    +import com.google.gson.Gson;
    +
    +public class StatementMetadata {
    +    
    +    private static Gson gson = new Gson();
    +    public static StatementMetadata EMPTY_METADATA = new StatementMetadata();
    +    
    +    private Map<String, String> metadataMap = new HashMap<String, String>();
    +    
    +    public StatementMetadata() {
    +        
    +    }
    +    
    +    public void addMetadata(String key, String value){
    --- End diff --
    
    This behaves like a "put" and not an "add".  Consider renaming this method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #122: adding metadata to individual statements

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-rya/pull/122


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---