You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/08/27 16:20:08 UTC

[GitHub] [helix] alirezazamani opened a new pull request #435: Cancel a Job might not update the jobContext

alirezazamani opened a new pull request #435: Cancel a Job might not update the jobContext
URL: https://github.com/apache/helix/pull/435
 
 
   ### Issues
   - [x] My PR addresses the following Helix issues and references them in the PR title:
   Issue #434 
   
   ### Description
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Once a job that is in running or init states get canceled:
   1- Participants can drop the job.
   2- As a result CurrentState will be null.
   3- If this situation happens, JobContext does not get updated.
   
   Solution: if CurrentState is null, JobContext will get updated by checking the TargetState.
   
   
   
   ### Tests
   
   - [x] The following is the result of the "mvn test" command on the appropriate module:
   
   Test Result 1: mvn test
   [INFO] Results:
   [INFO] 
   [ERROR] Failures: 
   [ERROR]   TestTaskPerformanceMetrics.testTaskPerformanceMetrics:118 expected:<true> but was:<false>
   [INFO] 
   [ERROR] Tests run: 844, Failures: 1, Errors: 0, Skipped: 0
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  50:50 min
   [INFO] Finished at: 2019-08-26T17:23:31-07:00
   [INFO] ------------------------------------------------------------------------
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project helix-core: There are test failures.
   [ERROR] 
   [ERROR] Please refer to /home/anajari/my_repos/helix/helix-core/target/surefire-reports for the individual test results.
   [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
   [ERROR] -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please read the following articles:
   [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
   
   
   Test Result 2: mvn test -Dtest="TestTaskPerformanceMetrics"
   [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.188 s - in org.apache.helix.monitoring.mbeans.TestTaskPerformanceMetrics
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  20.788 s
   [INFO] Finished at: 2019-08-26T17:25:41-07:00
   [INFO] ------------------------------------------------------------------------
   
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org