[GitHub] [lucene-solr] mayya-sharipova edited a comment on pull request #2186: LUCENE-9334 Consistency of field data structures

[GitBox <gi...@apache.org>]

mayya-sharipova edited a comment on pull request #2186:
URL: https://github.com/apache/lucene-solr/pull/2186#issuecomment-783604414


   @jpountz  Adrien, I also wanted to ask your opinion about the behaviour of `writer.updateDocValues(Term term, fieldX)`:
   1.  What should happen if `fieldX` doesn't exist in the segment (but exists globally)? 
   2. What should happen if `fieldX` doesn't have docValues enabled in the segment?
   
   Before in both of these cases `updateDocValues` worked well creating a field if it doesn't exist or enabling doc values.
   
   But with current PR as the field schema is fixed, we can:
   1. Allow the 1st case  with the assumption that the created field will only has docValues and nothing more.
   2. Throw an error on 2nd case, as docValues are not enabled.
   
   WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org