You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2016/12/06 17:05:31 UTC
kudu git commit: Update partition syntax for single value range
partitions
Repository: kudu
Updated Branches:
refs/heads/master 7959c7af7 -> 4201d370a
Update partition syntax for single value range partitions
Impala is going to use the singular form of 'value' for single-valued
range partitions.
Change-Id: I628a4ca81456ca22519e8b7cc5e176a7362a2669
Reviewed-on: http://gerrit.cloudera.org:8080/5368
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/4201d370
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/4201d370
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/4201d370
Branch: refs/heads/master
Commit: 4201d370ab599f9741b10ab543468335a6b876bf
Parents: 7959c7a
Author: Dan Burkert <da...@apache.org>
Authored: Mon Dec 5 17:01:36 2016 -0800
Committer: Dan Burkert <da...@apache.org>
Committed: Tue Dec 6 17:03:37 2016 +0000
----------------------------------------------------------------------
.../src/main/java/org/apache/kudu/client/Partition.java | 2 +-
.../src/test/java/org/apache/kudu/client/TestKuduTable.java | 6 +++---
src/kudu/common/partition.cc | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/4201d370/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
----------------------------------------------------------------------
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java b/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
index 1c4f810..fcad436 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
@@ -241,7 +241,7 @@ public class Partition implements Comparable<Partition> {
KeyEncoder.decodeRangePartitionKey(schema, partitionSchema, rangeKeyEnd);
if (PartialRow.isIncremented(lowerBound, upperBound, idxs)) {
- sb.append("VALUES = ");
+ sb.append("VALUE = ");
if (numColumns > 1) {
sb.append('(');
}
http://git-wip-us.apache.org/repos/asf/kudu/blob/4201d370/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
----------------------------------------------------------------------
diff --git a/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java b/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
index ab0af26..09ef520 100644
--- a/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
+++ b/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
@@ -354,7 +354,7 @@ public class TestKuduTable extends BaseKuduTest {
RangePartitionBound.INCLUSIVE_BOUND);
}
{
- expected.add("VALUES = 300");
+ expected.add("VALUE = 300");
PartialRow lower = basicSchema.newPartialRow();
lower.addInt(0, 300);
PartialRow upper = basicSchema.newPartialRow();
@@ -399,7 +399,7 @@ public class TestKuduTable extends BaseKuduTest {
builder.addRangePartition(schema.newPartialRow(), upper);
}
{
- expected.add("VALUES = (\"abc\", 0)");
+ expected.add("VALUE = (\"abc\", 0)");
PartialRow lower = schema.newPartialRow();
lower.addString(0, "abc");
lower.addByte(1, (byte) 0);
@@ -446,7 +446,7 @@ public class TestKuduTable extends BaseKuduTest {
builder.addRangePartition(schema.newPartialRow(), upper);
}
{
- expected.add("VALUES = \"abc\"");
+ expected.add("VALUE = \"abc\"");
PartialRow lower = schema.newPartialRow();
lower.addString(0, "abc");
PartialRow upper = schema.newPartialRow();
http://git-wip-us.apache.org/repos/asf/kudu/blob/4201d370/src/kudu/common/partition.cc
----------------------------------------------------------------------
diff --git a/src/kudu/common/partition.cc b/src/kudu/common/partition.cc
index 6d4f243..4dc63e9 100644
--- a/src/kudu/common/partition.cc
+++ b/src/kudu/common/partition.cc
@@ -686,7 +686,7 @@ string PartitionSchema::RangePartitionDebugString(const KuduPartialRow& lower_bo
if (upper_unbounded) {
return Substitute("VALUES >= $0", RangeKeyDebugString(lower_bound));
}
- // TODO(dan): recognize when a simplified 'VALUES =' form can be used (see
+ // TODO(dan): recognize when a simplified 'VALUE =' form can be used (see
// org.apache.kudu.client.Partition#formatRangePartition).
return Substitute("$0 <= VALUES < $1",
RangeKeyDebugString(lower_bound),