You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "li xu (Created) (JIRA)" <ji...@apache.org> on 2011/09/28 16:39:45 UTC
[jira] [Created] (SHINDIG-1632) EE and conservContainer page
doesn't run with context root other than Root
EE and conservContainer page doesn't run with context root other than Root
--------------------------------------------------------------------------
Key: SHINDIG-1632
URL: https://issues.apache.org/jira/browse/SHINDIG-1632
Project: Shindig
Issue Type: Bug
Components: Website
Affects Versions: 3.0.0
Reporter: li xu
Priority: Minor
Fix For: 3.0.0
Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1632) EE and conservContainer page
doesn't run with context root other than Root
Posted by "li xu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
li xu updated SHINDIG-1632:
---------------------------
Attachment: 20111012_selection_action.patch
Attach patch to include minor ui fix for selection/action sample page.
prefill gadget url field with correct context root.
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 20111012_selection_action.patch
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1632) EE and conservContainer page
doesn't run with context root other than Root
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127658#comment-13127658 ]
jiraposter@reviews.apache.org commented on SHINDIG-1632:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2587
-----------------------------------------------------------
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5817>
remove whitespace
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5818>
+18 seems a little fragile. Why not define /conservcontainer/ as a var and then get the length of the string
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5819>
remove the white space
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5820>
remove the white space and make sure it lines up
- Ryan
On 2011-10-12 20:54:19, li xu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2052/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-12 20:54:19)
bq.
bq.
bq. Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The fix will set up API patch when common container is created in these sample pages.
bq.
bq. var testConfig = testConfig || {};
bq. testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
bq. var CommonContainer = new osapi.container.Container(testConfig);
bq.
bq. also includes other minor cleanup.
bq.
bq.
bq. This addresses bug SHINDIG-1632.
bq. https://issues.apache.org/jira/browse/SHINDIG-1632
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/conservcontainer/index.html 1182418
bq.
bq. Diff: https://reviews.apache.org/r/2052/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. passed maven build.
bq.
bq.
bq. Thanks,
bq.
bq. li
bq.
bq.
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 20111012_selection_action.patch
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1632) EE and conservContainer page
doesn't run with context root other than Root
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127738#comment-13127738 ]
jiraposter@reviews.apache.org commented on SHINDIG-1632:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
-----------------------------------------------------------
(Updated 2011-10-14 18:01:40.220430)
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Changes
-------
Updated patch with comments.
Summary
-------
The fix will set up API patch when common container is created in these sample pages.
var testConfig = testConfig || {};
testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
var CommonContainer = new osapi.container.Container(testConfig);
also includes other minor cleanup.
This addresses bug SHINDIG-1632.
https://issues.apache.org/jira/browse/SHINDIG-1632
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/conservcontainer/index.html 1182572
Diff: https://reviews.apache.org/r/2052/diff
Testing
-------
passed maven build.
Thanks,
li
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 20111012_selection_action.patch
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1632) EE and conservContainer page
doesn't run with context root other than Root
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127791#comment-13127791 ]
jiraposter@reviews.apache.org commented on SHINDIG-1632:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2596
-----------------------------------------------------------
Ship it!
Committed revision 1183460.
- Ryan
On 2011-10-14 18:01:40, li xu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2052/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-14 18:01:40)
bq.
bq.
bq. Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The fix will set up API patch when common container is created in these sample pages.
bq.
bq. var testConfig = testConfig || {};
bq. testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
bq. var CommonContainer = new osapi.container.Container(testConfig);
bq.
bq. also includes other minor cleanup.
bq.
bq.
bq. This addresses bug SHINDIG-1632.
bq. https://issues.apache.org/jira/browse/SHINDIG-1632
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/conservcontainer/index.html 1182572
bq.
bq. Diff: https://reviews.apache.org/r/2052/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. passed maven build.
bq.
bq.
bq. Thanks,
bq.
bq. li
bq.
bq.
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 20111012_selection_action.patch, 20111014_selection_action.patch
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1632) EE and conservContainer page
doesn't run with context root other than Root
Posted by "li xu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
li xu updated SHINDIG-1632:
---------------------------
Attachment: 20111014_selection_action.patch
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 20111012_selection_action.patch, 20111014_selection_action.patch
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1632) EE and conservContainer page
doesn't run with context root other than Root
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126145#comment-13126145 ]
jiraposter@reviews.apache.org commented on SHINDIG-1632:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
-----------------------------------------------------------
(Updated 2011-10-12 20:54:19.017987)
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Changes
-------
Part of the issue is resolved by Dan's fix -- issue 1627.
Update the patch to only include the minor ui fix for Action/Selection Sample page...
Prefill the gadget url text field with correct context.
Summary
-------
The fix will set up API patch when common container is created in these sample pages.
var testConfig = testConfig || {};
testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
var CommonContainer = new osapi.container.Container(testConfig);
also includes other minor cleanup.
This addresses bug SHINDIG-1632.
https://issues.apache.org/jira/browse/SHINDIG-1632
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/conservcontainer/index.html 1182418
Diff: https://reviews.apache.org/r/2052/diff
Testing
-------
passed maven build.
Thanks,
li
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1632) EE and conservContainer page
doesn't run with context root other than Root
Posted by "li xu (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
li xu resolved SHINDIG-1632.
----------------------------
Resolution: Fixed
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 20111012_selection_action.patch, 20111014_selection_action.patch
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1632) EE and conservContainer page
doesn't run with context root other than Root
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116522#comment-13116522 ]
jiraposter@reviews.apache.org commented on SHINDIG-1632:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
-----------------------------------------------------------
(Updated 2011-09-28 14:42:55.071479)
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Changes
-------
Attach issue 1632 to this request.
Summary
-------
The fix will set up API patch when common container is created in these sample pages.
var testConfig = testConfig || {};
testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
var CommonContainer = new osapi.container.Container(testConfig);
also includes other minor cleanup.
This addresses bug SHINDIG-1632.
https://issues.apache.org/jira/browse/SHINDIG-1632
Diffs
-----
/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
/trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
Diff: https://reviews.apache.org/r/2052/diff
Testing
-------
passed maven build.
Thanks,
li
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1632) EE and conservContainer page doesn't
run with context root other than Root
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1632.
---------------------------------
part of 2.5.0-beta1 release.
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 2.5.0-beta1
> Reporter: li xu
> Priority: Minor
> Fix For: 2.5.0-beta1
>
> Attachments: 20111012_selection_action.patch, 20111014_selection_action.patch
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira