[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #612: (WIP) Fixing source schema and writer schema distinction in payloads

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #612: (WIP) Fixing source schema and writer schema distinction in payloads
URL: https://github.com/apache/incubator-hudi/pull/612#discussion_r268368530
 
 

 ##########
 File path: hoodie-common/src/main/java/com/uber/hoodie/common/model/HoodieAvroPayload.java
 ##########
 @@ -62,7 +62,6 @@ public HoodieAvroPayload preCombine(HoodieAvroPayload another) {
     if (recordBytes.length == 0) {
       return Optional.empty();
     }
-    Optional<GenericRecord> record = Optional.of(HoodieAvroUtils.bytesToAvro(recordBytes, schema));
-    return record.map(r -> HoodieAvroUtils.rewriteRecord(r, schema));
+    return Optional.of(HoodieAvroUtils.bytesToAvro(recordBytes, schema));
 
 Review comment:
   Good cleanup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services