You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/22 01:17:30 UTC
[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5171
Change subject: [TestSignalStackTrace] scope cleanup for test thread
......................................................................
[TestSignalStackTrace] scope cleanup for test thread
Use scope clean-up object to allow the test thread to join if the test
fails somewhere in the middle. This helps to avoid TSAN warnings on
read/write races.
Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2
---
M src/kudu/util/debug-util-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/5171/1
--
To view, visit http://gerrit.cloudera.org:8080/5171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [TestSignalStackTrace] scope cleanup for test thread
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5171/1/src/kudu/util/debug-util-test.cc
File src/kudu/util/debug-util-test.cc:
Line 87: auto cleanup_thr = MakeScopedCleanup([&]() { t->Join(); });
> Doesn't it also need to do l.CountDown() though? Otherwise t won't exit.
Good catch. It seems I missed the essence here :)
--
To view, visit http://gerrit.cloudera.org:8080/5171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [TestSignalStackTrace] scope cleanup for test thread
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [TestSignalStackTrace] scope cleanup for test thread
......................................................................
[TestSignalStackTrace] scope cleanup for test thread
Use scope clean-up object to allow the test thread to join if the test
fails somewhere in the middle. This helps to avoid TSAN warnings on
read/write races in such cases.
Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2
---
M src/kudu/util/debug-util-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/5171/2
--
To view, visit http://gerrit.cloudera.org:8080/5171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [TestSignalStackTrace] scope cleanup for test thread
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5171/1/src/kudu/util/debug-util-test.cc
File src/kudu/util/debug-util-test.cc:
Line 87: auto cleanup_thr = MakeScopedCleanup([&]() { t->Join(); });
Doesn't it also need to do l.CountDown() though? Otherwise t won't exit.
And if it's also counting down, you don't need L130-L133 at all.
--
To view, visit http://gerrit.cloudera.org:8080/5171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [TestSignalStackTrace] scope cleanup for test thread
......................................................................
[TestSignalStackTrace] scope cleanup for test thread
Use scope clean-up object to allow the test thread to join if the test
fails somewhere in the middle. This helps to avoid TSAN warnings on
read/write races in such cases.
Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2
Reviewed-on: http://gerrit.cloudera.org:8080/5171
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/debug-util-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins