You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Lavkesh Lahngir <la...@gmail.com> on 2017/04/18 06:41:45 UTC

Review Request 58496: Review comments on the MaxCoveringFactResolver

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58496/
-----------------------------------------------------------

Review request for lens and Puneet Gupta.


Bugs: LENS-1391
    https://issues.apache.org/jira/browse/LENS-1391


Repository: lens


Description
-------

Comments and cleanup


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 1c0d356 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java a9bd164 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 34180d1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java d95cf27 
  lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 064da01 


Diff: https://reviews.apache.org/r/58496/diff/1/


Testing
-------


Thanks,

Lavkesh Lahngir

Re: Review Request 58496: Review comments on the MaxCoveringFactResolver

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58496/#review172174
-----------------------------------------------------------


Ship it!




Ship It!

- Puneet Gupta


On April 18, 2017, 6:41 a.m., Lavkesh Lahngir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58496/
> -----------------------------------------------------------
> 
> (Updated April 18, 2017, 6:41 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1391
>     https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Comments and cleanup
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 1c0d356 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java a9bd164 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 34180d1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java d95cf27 
>   lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 064da01 
> 
> 
> Diff: https://reviews.apache.org/r/58496/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>