[jira] [Resolved] (PROTON-1093) [proton-c++] pragma to hide a warning in GCC introduces a warning in Windows

["Alan Conway (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PROTON-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Conway resolved PROTON-1093.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.12.0

> [proton-c++] pragma to hide a warning in GCC introduces a warning in Windows
> ----------------------------------------------------------------------------
>
>                 Key: PROTON-1093
>                 URL: https://issues.apache.org/jira/browse/PROTON-1093
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: 0.12.0
>         Environment: Visual Studio 20xx
>            Reporter: Chuck Rolke
>            Assignee: Chuck Rolke
>             Fix For: 0.12.0
>
>
> proton-c\bindings\cpp\src\contexts.cpp(48) : warning C4068: unknown pragma
> #pragma GCC diagnostic ignored "-Wold-style-cast"
> commit fd52a33
> I propose fixing this by moving the pragma into cmake to leave the source with no #pragma and with no conditional to hide the pragma.
> Windows has plenty of other warnings if we're serious about squelching them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)