[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3129: work in progress to upgrade to gradle 5

[GitBox <gi...@apache.org>]

autumnust commented on a change in pull request #3129:
URL: https://github.com/apache/incubator-gobblin/pull/3129#discussion_r506792323



##########
File path: gobblin-modules/gobblin-elasticsearch-deps/build.gradle
##########
@@ -21,7 +21,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.github.jengelman.gradle.plugins:shadow:2.0.4'
+        classpath 'com.github.jengelman.gradle.plugins:shadow:4.0.4'

Review comment:
       You may want to add a comment for the reasons why it needs to be upgraded. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org