[GitHub] [lucene] uschindler commented on a change in pull request #32: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #32:
URL: https://github.com/apache/lucene/pull/32#discussion_r600711473



##########
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##########
@@ -46,6 +47,7 @@
  */
 public abstract class BaseCompositeReader<R extends IndexReader> extends CompositeReader {
   private final R[] subReaders;
+  final Comparator<R> subReadersSorter;

Review comment:
       Why is this package protected? This is a public class, so if it is needed by subclasses, it needs to be protected. If it is not needed by subclasses, make it private.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org