You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/17 10:07:00 UTC

[jira] [Commented] (FLINK-9862) Update end-to-end test to use RocksDB backed timers

    [ https://issues.apache.org/jira/browse/FLINK-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546301#comment-16546301 ] 

ASF GitHub Bot commented on FLINK-9862:
---------------------------------------

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/6351

    [FLINK-9862] [test] Extend general puropose DataStream test to have a tumbling window

    ## What is the purpose of the change
    
    This allows our end-to-end tests to have coverage for snapshotting / restoring timers, when configured to use different state backends.
    
    ## Brief change log
    
    - Add a tumbling window to the `DataStreamAllAroundTestProgram`
    - Change default "max out of orderness" setting of the source generator to 0
    
    ## Verifying this change
    
    This is a change that affects existing tests
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-9862

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6351
    
----
commit a3bc102303481fa784b9c94d7838b1c2b5f65123
Author: Tzu-Li (Gordon) Tai <tz...@...>
Date:   2018-07-17T10:00:40Z

    [FLINK-9862] [test] Extend general puropose DataStream test to have a tumbling window
    
    This allows the end-to-end tests to have coverage for testing
    checkpointing timers.

----


> Update end-to-end test to use RocksDB backed timers
> ---------------------------------------------------
>
>                 Key: FLINK-9862
>                 URL: https://issues.apache.org/jira/browse/FLINK-9862
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing, Streaming
>    Affects Versions: 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We should add or modify an end-to-end test to use RocksDB backed timers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)