[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7587: GEODE-10035: fix BufferPool sys prop logic

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on code in PR #7587:
URL: https://github.com/apache/geode/pull/7587#discussion_r849908225


##########
geode-core/src/test/java/org/apache/geode/internal/net/BufferPoolTest.java:
##########
@@ -175,4 +181,39 @@ public void checkBufferSizeAfterAcquire() throws Exception {
     assertThat(newBuffer.limit()).isEqualTo(15000);
   }
 
+  @Test

Review Comment:
   Please convert to JUnit 5 and use system properties annotations from Pioneer.
   https://junit-pioneer.org/docs/system-properties/



##########
geode-core/src/test/java/org/apache/geode/internal/net/BufferPoolTest.java:
##########
@@ -22,12 +22,18 @@
 import java.nio.ByteBuffer;
 
 import org.junit.Before;
+import org.junit.Rule;
 import org.junit.Test;
+import org.junit.contrib.java.lang.system.RestoreSystemProperties;
 
 import org.apache.geode.distributed.internal.DMStats;
+import org.apache.geode.util.internal.GeodeGlossary;
 
 public class BufferPoolTest {
 
+  @Rule
+  public final RestoreSystemProperties restorer = new RestoreSystemProperties();

Review Comment:
   Using Junit5 and Pioneer system properties annotations will eliminate need for this legacy rule.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org